Warn about or refrain from automatic sys-usb restart after update when USB devices are connected

[kaie]

How to file a helpful issue

Qubes OS release

latest

Brief summary

sys-net/usb automatically restarting after updates detaches disks from VMs and causes trouble for ongoing disk operations.

Steps to reproduce

I'm using sys-net for both network and USB. I had an USB disk attached to a VM/Qube, and there was a copy operation running inside. I started Qubes updates from the notification menu. When the updates were done, I clicked next. Qubes OS automatically restarted sys-net. That caused the USB disk to get detached from the VM. VM still thought it had the USB disk connected, but couldn't umount it. Shutting down the VM got stuck, had to kill.

Expected behavior

sys-net/usb should NOT automatically restart if there are any connected USB disks (or other USB devices) to any running VMs.

Actual behavior

sys-net/usb restarts after update and causes ongoing disk operations on attached USB disks to fail

[kaie]

When in doubt, I'd prefer no automatic restarts at all.

[andrewdavidwong]

When in doubt, I'd prefer no automatic restarts at all.

You can turn this off: Gear icon > "Automatic restart after update" > uncheck boxes

[kaie]

You can turn this off: Gear icon > "Automatic restart after update" > uncheck boxes

Thank you

[juju4]

You can turn this off: Gear icon > "Automatic restart after update" > uncheck boxes Found in Qubes OS Update: gear > "Restart all service qubes after update by default" - unchecked

Still, I agree that a dynamic warning when upgrading and when offering to reboot if usb devices are connected, especially more for block devices (aka disks). Would avoid issue when user is not paying attention. (tested on 4.2.3)