qvm-sync-appmenus warning when .desktop name field contains an "!"

[svdm-artix]

Qubes OS version

4.1 beta, problem occurs in an archlinux template provided by unman

Which testing repositories are you using, if any?

None on this machine

Are you providing feedback about a specific package or packages in testing?

I may be providing feedback about a specific package, but I'm not sure which one.

Affected component(s) or functionality

qvm-sync-appmenus used on an archlinux template

---

Brief summary

When using qvm-sync-appmenus I get an error. "warning: ignoring key 'Name' of org.gnome.GTG". This seems to be due to the Name field in the desktop file containing an "!". I have already sent a bug report upstream (https://github.com/getting-things-gnome/gtg/issues/692). I think this is a Qubes OS bug though. It doesn't seem like anyone else is affected.

How reproducible

Always (for me at least)

Steps to reproduce

1. install archlinux template
2. install GTG through the AUR or chaotic aur
3. desktop icon doesn't show up, use qvm-sync-appmenus and see error

Expected behavior

Have the desktop entry show up in the qubes settings applications menu

Actual behavior

Icon doesn't show up in application menu, can only launch with qvm-run -p X 'gtg'

Solutions you've tried

Change .desktop name field to not include an "!"

Additional context

Can't think of anything I should include

---

Relevant documentation you've consulted

N/A

Related, non-duplicate issues

None found

[svdm-artix]

It seems important to mention that my solution worked, but it doesn't fix the core issue of qvm-sync-appmenus not working (for the end user it seems that way at least)

[DemiMarie]

@marmarek @HW42 Is adding ! to the list of allowed characters okay from a security perspective?

[rapenne-s]

ping? The issue is still relevant

[github-actions[bot]]

This issue is being closed because:

• This issue is believed to affect only Qubes OS 4.1 (and possibly earlier).
• Qubes OS 4.1 has reached end-of-life (EOL).

If anyone believes that this issue should be reopened, please leave a comment saying so. (For example, if a bug still affects Qubes OS 4.2, then the comment "Affects 4.2" will suffice.)

[DemiMarie]

This is definitely a Qubes OS issue that ought to be fixed. If @marmarek and @HW42 say this is okay w.r.t. security, I will send a PR.