qubes-core-admin icon indicating copy to clipboard operation
qubes-core-admin copied to clipboard

Published 20 hours ago β€’ verified publisher icon QubesOS

Add drive information to HCL

Open ben-grande opened this issue 1 month ago β€’ 1 comments

Disk information is already being reported for SCSI, but modern laptops may not have ATA and only have PCIe for NVMe.

Adding this information to disposable performance report may help understand the execution speed.

For: https://github.com/QubesOS/qubes-issues/issues/1512

i3 CPU with 16GB RAM is surprising that it could run the full performance test suite. Old disk that had many reads and writes can impact, but not sure it should be in the HCL.

ben-grande avatar Oct 23 '25 09:10 ben-grande

Codecov Report

:x: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.68%. Comparing base (56fefc3) to head (1dcc889).

Files with missing lines Patch % Lines
qubes/ext/utils.py 0.00% 1 Missing :warning:
qubes/qmemman/systemstate.py 0.00% 1 Missing :warning:
qubes/rngdoc.py 0.00% 1 Missing :warning:
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files          61       61           
  Lines       13809    13809           
=======================================
  Hits         9761     9761           
  Misses       4048     4048
Flag Coverage Ξ”
unittests 70.68% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 23 '25 10:10 codecov[bot]

black complains

marmarek avatar Nov 11 '25 03:11 marmarek

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025112611-4.3&flavor=pull-requests

Test run included the following:

  • https://github.com/QubesOS/qubes-core-admin-client/pull/332 (https://github.com/QubesOS/qubes-core-admin-client/pull/332/commits/40487bcb59ff4a704248144f4783ce0b0e1532b8)
  • https://github.com/QubesOS/qubes-core-admin-client/pull/397 (https://github.com/QubesOS/qubes-core-admin-client/pull/397/commits/c95a89cb9aa9179a8d4fd57480a3a3c304c6de8f)
  • https://github.com/QubesOS/qubes-core-admin/pull/736 (https://github.com/QubesOS/qubes-core-admin/pull/736/commits/a3fc21c156442bb42fa5e13c994c3dfb51ba5e1c)
  • https://github.com/QubesOS/qubes-core-admin/pull/744 (https://github.com/QubesOS/qubes-core-admin/pull/744/commits/d0c8a57ac8f0a593aff827b3f1d4e3891ba9f59b)
  • https://github.com/QubesOS/qubes-core-admin/pull/755 (https://github.com/QubesOS/qubes-core-admin/pull/755/commits/ccc46bcb8868d21b2883fe0bd7060c4a6171a740)
  • https://github.com/QubesOS/qubes-core-admin/pull/756 (https://github.com/QubesOS/qubes-core-admin/pull/756/commits/11867941c2ef12fa6837aa486c6d69b9b8db1358)
  • https://github.com/QubesOS/qubes-desktop-linux-i3-settings-qubes/pull/21 (https://github.com/QubesOS/qubes-desktop-linux-i3-settings-qubes/pull/21/commits/bc2319e27b26d84793190c11588e44b50d6cfa96)
  • https://github.com/QubesOS/qubes-gui-agent-linux/pull/251 (https://github.com/QubesOS/qubes-gui-agent-linux/pull/251/commits/3e53341a588f0704802a440afa0c4b1c3204bbdd)
  • https://github.com/QubesOS/qubes-gui-daemon/pull/173 (https://github.com/QubesOS/qubes-gui-daemon/pull/173/commits/d37169cd7bd2778651801e93e835e0a568d19a54)

Upload failures

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update

Failed tests

24 failures

  • system_tests_basic_vm_qrexec_gui

    • TC_20_NonAudio_whonix-gateway-18: test_000_start_shutdown (error + timed out) qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

  • system_tests_network_ipv6

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected) # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died) # Test died: command 'qvm-run -pu root work systemctl --wait is-sys...

  • system_tests_guivm_vnc_gui_interactive

    • guivm_manager: unnamed test (unknown)
    • guivm_manager: Failed (test died) # Test died: no candidate needle with tag(s) 'qubes-qube-manager' m...

  • system_tests_audio@hw1

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown) Whonixcheck for sys-whonix failed...

    • whonixcheck: Failed (test died) # Test died: systemcheck failed at qubesos/tests/whonixcheck.pm lin...

  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died) # Test died: no candidate needle with tag(s) 'windows-Edge-address-...

  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected) # wait_serial expected: qr/iDVvW-\d+-/...

    • windows_install: Failed (test died + timed out) # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_dispvm_perf@hw7

    • integ: dispvm_perf (error) NameError: name 'unittest' is not defined. Did you mean: 'run_test'...

  • system_tests_guivm_gpu_gui_interactive@hw13

    • gui_keyboard_layout: Failed (test died) # Test died: command 'test "$(qvm-run --nogui -p sys-gui-gpu 'ls e1...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/158999#dependencies

19 fixed

  • system_tests_extra

    • system_tests: Fail (unknown) Tests qubes.tests.extra failed (exit code 1), details reported sepa...

    • system_tests: Failed (test died) # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_00_QVCTest_debian-13-xfce: test_010_screenshare (failure + cleanup) AssertionError: 2.4614345149565264 not less than 2.0

    • TC_00_QVCTest_whonix-gateway-18: test_010_screenshare (failure) AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

    • TC_00_QVCTest_whonix-workstation-18: test_010_screenshare (failure) AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

  • system_tests_guivm_gui_interactive

    • gui_keyboard_layout: unnamed test (unknown)
    • gui_keyboard_layout: Failed (test died) # Test died: no candidate needle with tag(s) 'work-xterm, work-xter...

  • system_tests_dispvm

    • system_tests: Fail (unknown) Tests qubes.tests.integ.dispvm failed (exit code 1), details report...

    • TC_20_DispVM_whonix-workstation-18: test_030_edit_file (failure) AssertionError: Timeout waiting for editor window

    • TC_20_DispVM_whonix-workstation-18: test_100_open_in_dispvm (failure) AssertionError: './open-file test.txt' failed with ./open-file test...

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died) # Test died: no candidate needle with tag(s) 'disp-text-editor' mat...

  • system_tests_qwt_win10@hw13

    • windows_install: wait_serial (wait serial expected) # wait_serial expected: qr/kauF4-\d+-/...

    • windows_install: Failed (test died + timed out) # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win10_seamless@hw13

  • system_tests_dispvm_perf@hw7

    • TC_00_DispVMPerf_debian-13-xfce: test_411_dom0_dispvm_preload_gui_concurrent_api (failure) AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...

    • TC_00_DispVMPerf_debian-13-xfce: test_900_reader (failure) AssertionError: '/usr/lib/qubes/tests/dispvm_perf_reader.py --templ...

    • TC_00_DispVMPerf_whonix-workstation-18: test_409_dom0_dispvm_preload_gui_api (failure) AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...

    • TC_00_DispVMPerf_whonix-workstation-18: test_900_reader (failure) AssertionError: '/usr/lib/qubes/tests/dispvm_perf_reader.py --templ...

Unstable tests

Performance Tests

Performance degradation:

12 performance degradations
  • debian-13-xfce_exec: 7.76 πŸ”» ( previous job: 6.42, degradation: 120.91%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 113264.00 πŸ”» ( previous job: 231269.00, degradation: 48.98%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 82969.00 πŸ”» ( previous job: 130397.00, degradation: 63.63%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 382691.00 πŸ”» ( previous job: 491827.00, degradation: 77.81%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6722.00 πŸ”» ( previous job: 10236.00, degradation: 65.67%)
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 93449.00 πŸ”» ( previous job: 137220.00, degradation: 68.10%)
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 310689.00 πŸ”» ( previous job: 355690.00, degradation: 87.35%)
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1470.00 πŸ”» ( previous job: 3964.00, degradation: 37.08%)
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 334154.00 πŸ”» ( previous job: 371835.00, degradation: 89.87%)
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 40260.00 πŸ”» ( previous job: 49472.00, degradation: 81.38%)
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 20337.00 πŸ”» ( previous job: 46842.00, degradation: 43.42%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 626.00 πŸ”» ( previous job: 861.00, degradation: 72.71%)

Remaining performance tests:

60 tests
  • debian-13-xfce_exec-root: 26.93 🟒 ( previous job: 27.48, improvement: 97.99%)
  • debian-13-xfce_socket: 8.47 🟒 ( previous job: 8.68, improvement: 97.60%)
  • debian-13-xfce_socket-root: 8.27 🟒 ( previous job: 8.40, improvement: 98.39%)
  • debian-13-xfce_exec-data-simplex: 69.18 πŸ”» ( previous job: 67.70, degradation: 102.20%)
  • debian-13-xfce_exec-data-duplex: 68.19 🟒 ( previous job: 69.20, improvement: 98.54%)
  • debian-13-xfce_exec-data-duplex-root: 88.70 πŸ”» ( previous job: 86.64, degradation: 102.37%)
  • debian-13-xfce_socket-data-duplex: 135.68 🟒 ( previous job: 136.31, improvement: 99.54%)
  • fedora-42-xfce_exec: 9.06 🟒 ( previous job: 9.23, improvement: 98.17%)
  • fedora-42-xfce_exec-root: 59.78 🟒 ( previous job: 59.89, improvement: 99.81%)
  • fedora-42-xfce_socket: 8.16 🟒 ( previous job: 8.23, improvement: 99.15%)
  • fedora-42-xfce_socket-root: 8.14 🟒 ( previous job: 8.31, improvement: 97.91%)
  • fedora-42-xfce_exec-data-simplex: 67.40 πŸ”» ( previous job: 66.18, degradation: 101.85%)
  • fedora-42-xfce_exec-data-duplex: 67.13 🟒 ( previous job: 71.51, improvement: 93.88%)
  • fedora-42-xfce_exec-data-duplex-root: 101.71 πŸ”» ( previous job: 96.52, degradation: 105.38%)
  • fedora-42-xfce_socket-data-duplex: 132.75 🟒 ( previous job: 137.78, improvement: 96.35%)
  • whonix-gateway-18_exec: 8.22 🟒 ( previous job: 8.52, improvement: 96.56%)
  • whonix-gateway-18_exec-root: 126.72 🟒 ( previous job: 129.05, improvement: 98.19%)
  • whonix-gateway-18_socket: 8.62 πŸ”» ( previous job: 8.26, degradation: 104.36%)
  • whonix-gateway-18_socket-root: 8.48 πŸ”» ( previous job: 7.76, degradation: 109.31%)
  • whonix-gateway-18_exec-data-simplex: 66.02 🟒 ( previous job: 73.13, improvement: 90.28%)
  • whonix-gateway-18_exec-data-duplex: 70.71 🟒 ( previous job: 71.98, improvement: 98.24%)
  • whonix-gateway-18_exec-data-duplex-root: 134.32 🟒 ( previous job: 146.68, improvement: 91.57%)
  • whonix-gateway-18_socket-data-duplex: 138.86 🟒 ( previous job: 142.71, improvement: 97.30%)
  • whonix-workstation-18_exec: 8.45 🟒 ( previous job: 8.85, improvement: 95.46%)
  • whonix-workstation-18_exec-root: 138.55 🟒 ( previous job: 149.84, improvement: 92.46%)
  • whonix-workstation-18_socket: 9.31 πŸ”» ( previous job: 9.12, degradation: 102.11%)
  • whonix-workstation-18_socket-root: 9.02 πŸ”» ( previous job: 8.75, degradation: 103.17%)
  • whonix-workstation-18_exec-data-simplex: 69.91 πŸ”» ( previous job: 67.02, degradation: 104.31%)
  • whonix-workstation-18_exec-data-duplex: 68.08 🟒 ( previous job: 69.25, improvement: 98.31%)
  • whonix-workstation-18_exec-data-duplex-root: 148.17 πŸ”» ( previous job: 146.32, degradation: 101.27%)
  • whonix-workstation-18_socket-data-duplex: 135.65 🟒 ( previous job: 139.15, improvement: 97.48%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 483660.00 🟒 ( previous job: 365230.00, improvement: 132.43%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 254446.00 🟒 ( previous job: 110619.00, improvement: 230.02%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 70394.00 🟒 ( previous job: 39923.00, improvement: 176.32%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 9000.00 🟒 ( previous job: 3264.00, improvement: 275.74%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11524.00 πŸ”» ( previous job: 12000.00, degradation: 96.03%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4842.00 🟒 ( previous job: 2099.00, improvement: 230.68%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 265395.00 🟒 ( previous job: 103611.00, improvement: 256.15%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 442250.00 🟒 ( previous job: 432938.00, improvement: 102.15%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 198832.00 🟒 ( previous job: 143368.00, improvement: 138.69%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 109938.00 🟒 ( previous job: 103977.00, improvement: 105.73%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8951.00 🟒 ( previous job: 8300.00, improvement: 107.84%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4254.00 🟒 ( previous job: 3936.00, improvement: 108.08%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 394646.00 🟒 ( previous job: 346866.00, improvement: 113.77%)
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 46201.00 🟒 ( previous job: 26931.00, improvement: 171.55%)
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 90932.00 🟒 ( previous job: 85360.00, improvement: 106.53%)
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8687.00 πŸ”» ( previous job: 8945.00, degradation: 97.12%)
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 616.00 🟒 ( previous job: 457.00, improvement: 134.79%)
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 110669.00 🟒 ( previous job: 108858.00, improvement: 101.66%)
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 317365.00 πŸ”» ( previous job: 351871.00, degradation: 90.19%)
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 90911.00 🟒 ( previous job: 75326.00, improvement: 120.69%)
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 1890.00 πŸ”» ( previous job: 1909.00, degradation: 99.00%)
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8507.00 🟒 ( previous job: 8365.00, improvement: 101.70%)
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1674.00 🟒 ( previous job: 517.00, improvement: 323.79%)
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 372760.00 🟒 ( previous job: 361328.00, improvement: 103.16%)
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 145616.00 🟒 ( previous job: 140939.00, improvement: 103.32%)
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 334474.00 πŸ”» ( previous job: 349176.00, degradation: 95.79%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 86470.00 🟒 ( previous job: 79581.00, improvement: 108.66%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3583.00 🟒 ( previous job: 2110.00, improvement: 169.81%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7900.00 🟒 ( previous job: 7708.00, improvement: 102.49%)

qubesos-bot avatar Nov 26 '25 17:11 qubesos-bot

So, always bothered me that tests are excluded from pylint, and it could have reported the error before being openqaed. I did add some files now, at least the ones I have made a lot of changes too. Some I didn't dare to touch because there were a lot of warnings.

ben-grande avatar Nov 26 '25 20:11 ben-grande