ipygany icon indicating copy to clipboard operation
ipygany copied to clipboard

Support Point Cloud

Open akaszynski opened this issue 4 years ago • 7 comments

Looking at pythreejs, it seems like it should be possible to add a point cloud. Any hints for getting this added? I'm fine with submitting a PR.

akaszynski avatar Mar 29 '21 20:03 akaszynski

My bad, it's in ipygany, just not documented: https://github.com/QuantStack/ipygany/blob/9181b7d5408ee0304f50ae3fd22beab45076224a/ipygany/ipygany.py#L426-L433

Would be nice to have docs and a from_pyvista method. Mind if I leave this open to remind myself?

akaszynski avatar Mar 29 '21 21:03 akaszynski

Almost there. Is there any way to change the size of the points?

pc

akaszynski avatar Mar 29 '21 21:03 akaszynski

Thanks for opening an issue!

Almost there. Is there any way to change the size of the points?

Unfortunately not yet. There are some limitations in the ThreeJS Materials I am using in ipygany (see https://github.com/mrdoob/three.js/issues/18153). I will try to allocate some time this week for this and other ipygany stuffs and release it :)

martinRenou avatar Mar 30 '21 06:03 martinRenou

I'm working on supporting ipygany in https://github.com/pyvista/pyvista/pull/1239, and adding features like point sizes and wireframes would be really helpful. I realize that much needs to be added under the hood to support this, but I'd really like to be able to mirror many of the features available in vtk.js to ipygany since threejs is a bit more performant. A few features would be super valuable like:

  • wireframe representation
  • opacity
  • lighting control
  • Unbuffered arrays (enables smooth shading and seems more efficient)

Please let me know if I can help out.

akaszynski avatar Mar 30 '21 14:03 akaszynski

Any update on this?

deeplook avatar Jan 14 '22 13:01 deeplook

Note that pyvista now supports using pythreejs: https://docs.pyvista.org/user-guide/jupyter/pythreejs.html

You can use a ton of features that are unavailable in ipygany.

akaszynski avatar Jan 14 '22 17:01 akaszynski

Correct, I'm using it already. 😉

deeplook avatar Jan 14 '22 18:01 deeplook