lecture-python-intro icon indicating copy to clipboard operation
lecture-python-intro copied to clipboard

[geom_series] Add an exercise

Open SylviaZhaooo opened this issue 1 year ago β€’ 19 comments
trafficstars

Dear John @jstac,

Same as before, I changed the last part, the Keynesian model with plots and code snippets part, into an exercise since the logic of this model has been illustrated so it is easy to have the same model as an exercise.

Fixes #401

Best, Sylvia

SylviaZhaooo avatar Jul 22 '24 04:07 SylviaZhaooo

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
Latest commit d47d7dadad60354acbfb0ea6880cba8ec1a62577
Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/684f75bc1fa29e00081bfd73
Deploy Preview https://deploy-preview-524--taupe-gaufre-c4e660.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jul 22 '24 04:07 netlify[bot]

πŸš€ Deployed on https://684f77b49867bba1b9407706--taupe-gaufre-c4e660.netlify.app

github-actions[bot] avatar Jul 22 '24 04:07 github-actions[bot]

Hi @mmcky,

I think the connection issue comes up again from the Anaconda side:

  ('Connection broken: IncompleteRead(260439 bytes read, 1980267 more expected)', IncompleteRead(260439 bytes read, 1980267 more expected))

HumphreyYang avatar Jul 22 '24 05:07 HumphreyYang

thanks @HumphreyYang -- just triggered a rebuild.

mmcky avatar Jul 22 '24 06:07 mmcky

Many thanks @SylviaZhaooo .

Does this pull request address a particular issue? (If yes, then you can put "Fixes #XXX", where XXX is the issue number, and the issue will be closed automatically when this PR is merged.)

Does the reader have enough information to complete the exercise? For example, do they need to know parameter values?

@shlff , could you please review this carefully and work with @SylviaZhaooo to finish it? If I look at https://669dffc4710cf5c7cb257aa4--taupe-gaufre-c4e660.netlify.app/geom_series, it seems that a lot of extra content is included in the solution --- "We now examine what will happen..."

jstac avatar Jul 22 '24 20:07 jstac

Thanks @SylviaZhaooo and @jstac .

Hi @SylviaZhaooo I had a look at this PR, and I suggest we break this section into 2 or more exercises

  • 1: plot the time path;
  • 2: plot the time paths with different marginal propensity to consume, or varied investment or different government spending (the second could be broke into parts))

After breaking it down, we then polish the exercise titles and solutions one by one.

shlff avatar Jul 23 '24 04:07 shlff

@shlff I made some changes. Does it look good to you?

SylviaZhaooo avatar Jul 23 '24 12:07 SylviaZhaooo

Thanks @SylviaZhaooo . Excellent job!

I will push some of my modifications.

shlff avatar Jul 24 '24 00:07 shlff

Hi @mmcky and @SylviaZhaooo do we wish to merge this PR tonight?

shlff avatar Jul 24 '24 07:07 shlff

I just ran the spell check. It should be fine now @mmcky.

SylviaZhaooo avatar Jul 24 '24 07:07 SylviaZhaooo

Now the PR looks good on my side. Can you take another review @SylviaZhaooo ?

If you are happy, then we could pass it to @mmcky to decide whether to merge it or not.

shlff avatar Jul 24 '24 07:07 shlff

It looks good to me. Many thanks @shlff.

SylviaZhaooo avatar Jul 24 '24 07:07 SylviaZhaooo

Hi @mmcky this PR is ready for you to review.

shlff avatar Jul 24 '24 08:07 shlff

Hi @mmcky,

I think these are values = [0.3, 0.4] for the comparative analysis just like what we did for i in the first question of the third exercise and I revised the statement and kept it the same as the statement for i.

SylviaZhaooo avatar Oct 11 '24 04:10 SylviaZhaooo

Thanks @SylviaZhaooo and @mmcky .

Hi @SylviaZhaooo , I had a look at the code and I suggested the following modifications to improve the clarity.

You can vote if we should adopt these.

shlff avatar Oct 12 '24 05:10 shlff

Hi @shlff,

Thanks for your suggestions! I've reviewed your modifications and committed all the changes. Let me know if there’s anything else you’d like me to adjust or if further improvements are needed.

SylviaZhaooo avatar Oct 13 '24 12:10 SylviaZhaooo

Thanks @SylviaZhaooo . It looks better to me now.

If you are happy with it, then we could hand it over to @mmcky for a final review.

Hi @mmcky here is a link to the most recent preview: https://670a4ceac856cc023983ef0f--taupe-gaufre-c4e660.netlify.app/geom_series

shlff avatar Oct 13 '24 21:10 shlff

thanks @shlff and @SylviaZhaooo -- I think this is looking good. πŸ‘

mmcky avatar Oct 15 '24 01:10 mmcky

@jstac this is ready for final review and merge.

mmcky avatar Oct 15 '24 02:10 mmcky