lecture-python-intro icon indicating copy to clipboard operation
lecture-python-intro copied to clipboard

Published 20 hours ago • verified publisher icon QuantEcon

MAINT: update to use `remarks` admonition once style is updated

Open mmcky opened this issue 1 year ago • 3 comments

There are lectures such as https://github.com/QuantEcon/lecture-python-intro/pull/440#discussion_r1594822289

that make use of remarks that could be nicely wrapped in admonitions, however the style is currently overly bold in sphinx-proof and gives too much weight to the contents.

Once https://github.com/executablebooks/sphinx-proof/issues/98 is resolved we can loop through and add the admonitions to this lecture series.

mmcky avatar May 09 '24 04:05 mmcky

@longye-tian would you have time today to review this issue and setup a PR that includes a remark admonition that we can use as a test case.

I will coordinate updates to the theme but it would be helpful to see how they look in a real work case.

mmcky avatar Jun 30 '24 23:06 mmcky

Started the process of updating sphinx-proof with a maintenance PR today.

https://github.com/executablebooks/sphinx-proof/pull/99

Once that is accepted and merged we can then make progress on improvements to the style

mmcky avatar Jul 01 '24 04:07 mmcky

This PR is now open

https://github.com/executablebooks/sphinx-proof/pull/106

mmcky avatar Jul 02 '24 06:07 mmcky