Build Warnings Overload

[C-SELLERS]

Expected Behavior

We ignore the warnings that are acceptable in our codebase to reduce build logs and improve visibility into new warnings and errors.

Actual Behavior

2000+ warnings in VS build

Potential Solution

Decide and then suppress acceptable warnings

Also maybe handle the warnings that are unacceptable.

Reproducing the Problem

Build Lean

Checklist

• [x] I have completely filled out this template
• [x] I have confirmed that this issue exists on the current master branch
• [x] I have confirmed that this is not a duplicate issue by searching issues

• [x] I have provided detailed steps to reproduce the issue

[C-SELLERS]

Closing this issue because of the merges that wiped a lot of the warnings. There will still be some ongoing but they are more difficult and involve some breaking changes.

[C-SELLERS]

With the recent upgrade to dotnet 5 framework a lot of new warnings have been generated. It would be great to clear these up so I am going to re-open this issue.

[Martin-Molinero]

In master we are currently at

• We can tackle this in ~100 fixes per PR
• For cases like "AAPL" to Symbol warning in user/example algorithms, maybe we can skip this warning in the project level C# QuantConnect.Algorithm.CSharp. For test project, we could fix or add pragma ignore if we need it cause we are actually testing it

---

• let's ignore this one, don't think it looks better but more confusing -> we can add it to project wise warning ignore

• let's ignore this one, requesting to add null checks on arguments passed in -> we can add it to project wise warning ignore

• let's avoid risky ones like missing dispose, unless in tests code where we can fix

• let's add a project wise ignore for this one

• skip these, not worth it

• Create TestException exception for our test project, replace exception, add argument expected vs current

[Martin-Molinero]

Still in progress