bloqade-python icon indicating copy to clipboard operation
bloqade-python copied to clipboard

Analysis functions ownership

Open jon-wurtz opened this issue 2 years ago • 2 comments

Should analysis functions be owned by job outputs, eg

emu_job.rydberg_densities()

or by a specific sub-module

bloqade.analysis.rydberg_densities(emu_job)

jon-wurtz avatar Jun 30 '23 13:06 jon-wurtz

I think the consistent design is the former as we do not want users to look for which module to use, there is only one module bloqade that needs to know in most of cases for a user, which is the current design. On the one hand, we can provide some more bare bone implementations within a module for those more hardcore users like what we did for the IR.

Roger-luo avatar Jul 03 '23 23:07 Roger-luo

https://github.com/Happy-Diode/bloqade-python/pull/335 Because I needed to do it sometime

jon-wurtz avatar Jul 26 '23 20:07 jon-wurtz