qiskit
qiskit copied to clipboard
Qiskit
Added parameters property to BindingsArray
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Qiskit/terra-core@ajavadia@levbishop@t-imamichi
Pull Request Test Coverage Report for Build 10249130397
Details
- 2 of 7 (28.57%) changed or added relevant lines in 1 file are covered.
- 17 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.02%) to 89.734%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| qiskit/primitives/containers/bindings_array.py | 2 | 7 | 28.57% |
| <!-- | Total: | 2 | 7 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| crates/qasm2/src/lex.rs | 5 | 92.73% |
| crates/qasm2/src/parse.rs | 12 | 97.15% |
| <!-- | Total: | 17 |
| Totals | |
|---|---|
| Change from base Build 10222290210: | -0.02% |
| Covered Lines: | 67338 |
| Relevant Lines: | 75042 |
💛 - Coveralls
Could you add a unit test of the method? I assigned @chriseclectic to review this PR.
