consider the planning horizon for biomass potentials input

[p-glaum]

build_sector.smk: always consider the planning horizon for biomass potentials input in prepare_sector_network

Changes proposed in this Pull Request

The problem was that for overnight, not the planning horizon was considered for the biomass potential but the year set in the config under biomass. This led to the unwanted behavior that one could not do a 2050 optimization with the biomass potentials from ENSPRESO for 2030 and without unsustainable biomass.

Checklist

• [ ] I tested my contribution locally and it works as intended.
• [ ] Code and workflow changes are sufficiently documented.
• [ ] Changed dependencies are added to envs/environment.yaml.
• [ ] Changes in configuration options are added in config/config.default.yaml.
• [ ] Changes in configuration options are documented in doc/configtables/*.csv.
• [ ] Sources of newly added data are documented in doc/data_sources.rst.
• [ ] A release note doc/release_notes.rst is added.

[github-actions[bot]]

Validator Report

I am the Validator. Download all artifacts here. I'll be back and edit this comment for each new commit.

General

Plots comparison

Main branch	Feature branch

Files comparison

	Status	NRMSE	MAE (norm)
nodal_capacities.csv	:warning: NaN mismatch
nodal_supply_energy.csv	:warning: NaN mismatch
costs.csv	:warning: NaN mismatch
cfs.csv	:warning: NaN mismatch
nodal_cfs.csv	:warning: NaN mismatch
nodal_costs.csv	:warning: NaN mismatch
capacities.csv	:warning: NaN mismatch
supply.csv	:warning: NaN mismatch
prices.csv	:warning: NaN mismatch
supply_energy.csv	:warning: NaN mismatch
energy.csv	:warning: NaN mismatch
price_statistics.csv	:white_check_mark: Almost equal	0.000	0.35
curtailment.csv	:white_check_mark: Almost equal	0.000	0.18
metrics.csv	:white_check_mark: Almost equal	0.004	0.16
weighted_prices.csv	:white_check_mark: Almost equal	0.558	0.41
market_values.csv	:white_check_mark: Almost equal	0.000	0.10

NRMSE: Normalized (min-max) Root Mean Square Error MAE (norm): Mean Absolute Error on normalized Data (min-max Status Threshold: MAE (norm) > 0.05 and NRMSE > 2

Model Metrics

Benchmarks

Comparing fix_biomass_input (40efa65) with master (38f2dc7). Branch is 3 commits ahead and 0 commits behind. Last updated on 2024-09-19 11:07:28 CEST.

[fneum]

This is the intended behavior that you can use 2030 biomass potentials for 2050 runs.

[p-glaum]

I think we are talking about different things here. You can still optimize a 2050 year with biomass potentials of 2030. It is only for the unsustainable fraction which is taken from year 2050.

[fneum]

Alright, I think I got it now. Will you do the adjustment we talked about, using planning horizon as key and ENSPRESO potential year as values in the config.yaml? Then, we can merge.

biomass:
  year:
    2020: 2020
    2025: 2025
    2030: 2030
    ...