pypsa-eur
pypsa-eur copied to clipboard
Update TYNDP projects in data/transmission_projects/manual
Closes # (if applicable).
Changes proposed in this Pull Request
- NorthConnect has been cancelled and was removed from the .csv file.
| TYNDP2018_190 | Simadalen (NO) | Peterhead (UK) | 650 | 1400 | in_permitting | {name:NorthConnect, url:https://tyndp.entsoe.eu/tyndp2018/projects/projects/190} | 7.16027 | 60.500527 | -1.784066 | 57.508123 | |
|---|---|---|---|---|---|---|---|---|---|---|---|
-
IFA 2 and Italy-France interconnector are already in operation. Should they be removed as well?
-
Build_years were added for all entries
-
Capacity was slightly decreased from 1400 to 1250 for two projects
Checklist
- [ ] I tested my contribution locally and it works as intended.
- [ ] Code and workflow changes are sufficiently documented.
- [ ] Changed dependencies are added to
envs/environment.yaml. - [ ] Changes in configuration options are added in
config/config.default.yaml. - [ ] Changes in configuration options are documented in
doc/configtables/*.csv. - [ ] Sources of newly added data are documented in
doc/data_sources.rst. - [ ] A release note
doc/release_notes.rstis added.
Validator Report
I am the Validator. Download all artifacts here. I'll be back and edit this comment for each new commit.
:exclamation: Run failed!
Download 'logs' artifact to see more details.
masterfailed in:no_logs_foundupdate-manual-tyndp-projectsfailed in:no_logs_found
Model Metrics
Benchmarks
Comparing update-manual-tyndp-projects (7b89abf) with master (27643f7).
Branch is 6 commits ahead and 0 commits behind.
Last updated on 2025-01-15 08:21:43 CET.
@lkstrp this validator is soo cool!
Hi @lindnemi ,
thanks a lot for the manual labor. Regarding your question:
IFA 2 and Italy-France interconnector are already in operation. Should they be removed as well?
Yes, I would remove them, because the catching of duplicates should work, but if we know the link is already in OSM, then we can also remove it to make sure it is not added twice.
Did you check if the lines were added correctly to resources/transmission_projects/new_links.csv?
- changed permissions
- changed coordinates, build_year and length of three TYNDP links to avoid duplicates with NEP
Hi @lindnemi, the PR looks good and drops the intended lines. However, I honestly do not understand why for you the duplicated links were still added in the master. I just ran the current master again and there the duplicated NEP links are not added. Here are the logs from my last run:
INFO:root:Processing new links projects from tyndp2020.
WARNING:__main__:Found new lines similar to existing lines:
{'TYNDP2020_29': 'relation/3391794', 'TYNDP2020_30': 'relation/9982798', 'TYNDP2020_36': 'relation/2127794'}
Lines are assumed to be duplicated and will be ignored.
INFO:root:Processing new lines projects from tyndp2020.
WARNING:__main__:Found new lines similar to existing lines:
{'TYNDP2020_32': '196723099-b', 'TYNDP2020_38': '209262460', 'TYNDP2020_39': '191187235', 'TYNDP2020_51': '875518342', 'TYNDP2020_58': '368921913', 'TYNDP2020_66': '178621799', 'TYNDP2020_93': '208243244', 'TYNDP2020_120': '881636336', 'TYNDP2020_135': '418614532', 'TYNDP2020_30': '1001117406', 'TYNDP2020_52': '862050701-2', 'TYNDP2020_60': '856645981'}
Lines are assumed to be duplicated and will be ignored.
INFO:root:Processing new links projects from nep.
WARNING:__main__:Found new lines similar to existing lines:
{'DC1': 'TYNDP2020_23', 'DC3': 'TYNDP2020_1', 'DC4': 'TYNDP2020_2'}
Lines are assumed to be duplicated and will be ignored.
INFO:root:Processing new lines projects from nep.
INFO:root:Processing new links projects from manual.
Just ran it again from pypsa-ariadne repo and the lines are still not dropped. I also noticed that the add_transmission_projects_and_dlr rule is not automatically triggered when the input files (i.e., data/transmission_projects/) change.
Hi @lindnemi, the PR looks good and drops the intended lines. However, I honestly do not understand why for you the duplicated links were still added in the master. I just ran the current master again and there the duplicated NEP links are not added. Here are the logs from my last run:
INFO:root:Processing new links projects from tyndp2020. WARNING:__main__:Found new lines similar to existing lines: {'TYNDP2020_29': 'relation/3391794', 'TYNDP2020_30': 'relation/9982798', 'TYNDP2020_36': 'relation/2127794'} Lines are assumed to be duplicated and will be ignored. INFO:root:Processing new lines projects from tyndp2020. WARNING:__main__:Found new lines similar to existing lines: {'TYNDP2020_32': '196723099-b', 'TYNDP2020_38': '209262460', 'TYNDP2020_39': '191187235', 'TYNDP2020_51': '875518342', 'TYNDP2020_58': '368921913', 'TYNDP2020_66': '178621799', 'TYNDP2020_93': '208243244', 'TYNDP2020_120': '881636336', 'TYNDP2020_135': '418614532', 'TYNDP2020_30': '1001117406', 'TYNDP2020_52': '862050701-2', 'TYNDP2020_60': '856645981'} Lines are assumed to be duplicated and will be ignored. INFO:root:Processing new links projects from nep. WARNING:__main__:Found new lines similar to existing lines: {'DC1': 'TYNDP2020_23', 'DC3': 'TYNDP2020_1', 'DC4': 'TYNDP2020_2'} Lines are assumed to be duplicated and will be ignored. INFO:root:Processing new lines projects from nep. INFO:root:Processing new links projects from manual.
Snakemake not triggering the recomputation of transmission_projects when the csvs change might be related to https://github.com/snakemake/snakemake/issues/2011
What's the status here?
No more duplicates occuring. If you are happy with the name changes i introduced to mention both TYNDP and NEP this can be merged.