powerplantmatching icon indicating copy to clipboard operation
powerplantmatching copied to clipboard

Complement data update 2025

Open jensch-dlr opened this issue 1 month ago • 2 comments

Closes # (if applicable).

Changes proposed in this Pull Request

I have tried to run the "data-update-2025" branch today and ran into some issues that this PR aims to improve. Here is a list of the changes I am proposing (that fixed every issue that I had):

  • Update GBPT importer to support newer version of the database (from V3 on without sheet "Below Threshold").
  • Correct GPD file name in config.yaml.
  • Set parallel_duke_processes to false (instead of 16) to make powerplantmatching executable out-of-the-box also for Windows systems.
  • Update path to powerplants.png in README.
  • Fix typo in docstring of gather_fueltype_info() (cleaning.py) and MASTR() (data.py).

Checklist

  • [x] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in docs. ~~- [ ] Unit tests for new features were added (if applicable).~~
  • [x] A note for the release notes docs/release_notes.md of the upcoming release is included.
  • [x] I consent to the release of this PR's code under the MIT license and have added my name to the docs/contributors.md.

jensch-dlr avatar Nov 03 '25 20:11 jensch-dlr

I am not sure were the test are failing. Locally they all finish successfully for me.

jensch-dlr avatar Nov 04 '25 09:11 jensch-dlr

Thanks @jensch-dlr, that looks all quite reasonable!

I am not sure were the test are failing. Locally they all finish successfully for me.

Yes, it's also a problem for the target branch. Nothing for you to worry about.

fneum avatar Nov 04 '25 09:11 fneum