pyo3 icon indicating copy to clipboard operation
pyo3 copied to clipboard

Published 20 hours ago • verified publisher icon PyO3

ci: Move netlify build into GitHub action

Open Cheukting opened this issue 6 months ago • 3 comments
trafficstars

Moving Netlify build to GitHub Action

see #5081

Cheukting avatar May 19 '25 17:05 Cheukting

@davidhewitt there are a bunch of ui output mismatches, do you mind having a look and seeing if they are correct?

Cheukting avatar May 20 '25 02:05 Cheukting

Rebasing on current main should fix it

Icxolu avatar May 20 '25 16:05 Icxolu

@davidhewitt Netlify auth fail, I think that need your attention

Cheukting avatar May 20 '25 19:05 Cheukting

Sorry to be slow to interact with this branch. I think to protect the secrets we have to do the upload in a workflow_run triggered action, will run in the context of main and we don't run untrusted code (apart from the netlify CLI) on that run.

davidhewitt avatar Jun 20 '25 17:06 davidhewitt

guide build failures should be fixed by #5203

davidhewitt avatar Jun 20 '25 17:06 davidhewitt

This seems promising to me, I'm going to merge it and see how it goes. Thanks!

davidhewitt avatar Jul 04 '25 12:07 davidhewitt

Thank you for bringing it to the finish line, hope it all goes well 🙏🏻

Cheukting avatar Jul 04 '25 12:07 Cheukting