maturin icon indicating copy to clipboard operation
maturin copied to clipboard

Add pypy and maybe graalpy support to `generate-ci`

Open messense opened this issue 1 year ago • 3 comments
trafficstars

we can add a new cli option --python-implementation to select python impls to build wheels for, it should support these options:

  • cpython (enabled by default)
  • pypy
  • graalpy (if we can upload graalpy wheels to pypi, need to check that)

https://github.com/PyO3/maturin/blob/main/src/ci.rs

messense avatar Mar 28 '24 01:03 messense

graalpy (if we can upload graalpy wheels to pypi, need to check that)

Aren't cffi wheels implementation independent?

So maybe that could just be based on the binding kind?

cpyext don't seem very encouraged 1 2 and e.g. documentation is basically nonexistent (and many old links are dead), it requires linking against pypy's headers and not linking against libpython, which I'm not sure pyo3 / maturin supports (I didn't really find any references to that anywhere), so I figured cffi was the more likely way to support pypy (and graal) if I wanted that.

masklinn avatar Aug 04 '24 19:08 masklinn

@masklinn Both PyPy and GraalPy are supported, see

  • https://github.com/PyO3/pyo3/pull/393
  • https://github.com/PyO3/pyo3/pull/3247

messense avatar Aug 05 '24 01:08 messense

@masklinn Both PyPy and GraalPy are supported, see

Thanks for the correction, are there docs around for those? I didn’t find anything when looking around maturin’s docs hence my belief that cffi would be the most well trodden path for pypy and graal (I understand uniffi also works with pypy, I wasn’t clear if it would work with graal at all).

masklinn avatar Aug 05 '24 07:08 masklinn