pycodestyle icon indicating copy to clipboard operation
pycodestyle copied to clipboard

Published 20 hours ago • verified publisher icon PyCQA

Collapsable Nodes

Open KiraPC opened this issue 2 years ago • 6 comments

I see here https://github.com/open-source-labs/Svelvet/issues/183 there was a way to enable collapsable nodes but I cannot found it on the new version of the lib.

How can I make it works?

I'm trying to implements it custom but when uncollapsing node, edges are not rendered if the connection size is not greater than the last max connections created before collapse (difficult to explain).

Here a sample video of what I'm facing https://github.com/open-source-labs/Svelvet/assets/46629148/76c0873d-ad6e-4bbc-91c9-609249efbb2f

KiraPC avatar May 09 '23 10:05 KiraPC

Hi, Kira. Yes, the implementation of unfold and collapse is different now since developers have total control over conditionally rendering Node components in the new version. We should be adding a native implementation for default nodes soon.

That said, what you’ve put together should work, so let me look into what’s happening with the edges. Are you able to share a sandbox?

briangregoryholmes avatar May 09 '23 12:05 briangregoryholmes

@briangregoryholmes Here the sandbox https://stackblitz.com/edit/svelvet-collapse

KiraPC avatar May 09 '23 13:05 KiraPC

Hi, Kira. I tracked down the issue and filed a PR. Unfortunately, the release cycle for Svelvet will be slowing down while the team works on the next major release, but it should be live in the next few weeks.

briangregoryholmes avatar May 09 '23 16:05 briangregoryholmes

Hi Brian,

Thank you for fixing the issue.

To continue working on my project, I just tried to install the branch but I'm facing the same behavior as before.

What I did was cloning the repository locally, made the build via npm, copying the dist folder inside my project node_modules. Am I missing somethings?

KiraPC avatar May 10 '23 07:05 KiraPC

It could be as simple as cleaning the npm cache, but that isn't something I'd necessarily recommend.

If your timeline allows, I can talk with the OS Labs administrators about pushing out a patch before our next release. I'll be adding a method to the Node component so that you can achieve this with a really simple function call.

briangregoryholmes avatar May 11 '23 00:05 briangregoryholmes

Hi,

I've just installed the branch as a local dependencies and it's working.

But a fastest release will very appreciate.

Anyway, for a library that the main feature is drawing a graph this could be a bug to be fixed as hot-fix 😄

KiraPC avatar May 11 '23 07:05 KiraPC