prospector icon indicating copy to clipboard operation
prospector copied to clipboard

[BUG] Vulture doesn't report `unused method` under Prospector

Open rpatterson opened this issue 2 years ago • 1 comments

Describe the bug

Running Vulture directly reports unused method:

$ vulture ./src/foo/
src/foo/bar.py:##: unused method 'qux' (##% confidence)

But running it under Prospector reports nothing:

$ prospector ./src/foo/
Check Information
=================
         Started: ####-##-## ##:##:##.######
        Finished: ####-##-## ##:##:##.######
      Time Taken: #.## seconds
       Formatter: grouped
        Profiles: .prospector.yaml, full_pep8, doc_warnings, strictness_veryhigh, member_warnings
      Strictness: from profile
  Libraries Used: 
       Tools Run: bandit, dodgy, mccabe, mypy, profile-validator, pycodestyle, pydocstyle, pyflakes, pylint, vulture
  Messages Found: 0
 External Config: pylint: ./pyproject.toml

Environment:

  • OS: Docker python:3.11 image
  • Tool: pylint
  • Prospector version: v1.9.0
  • Python version: v3.11.2

rpatterson avatar Feb 26 '23 16:02 rpatterson

I'm guessing this is because Prospector hard codes the vulture checks to perform? Maybe it would be best to find someway to let Vulture define the list of checks it performs so that they're included in Prospector as Vulture changes?

rpatterson avatar Feb 26 '23 16:02 rpatterson

Issue closed because there are no resent messages, if you are still impacted please, test with the latest version of Prospector (>= 1.12.1) and reopen it with a message like "still valid, tested with the version ".

sbrunner avatar Oct 11 '24 10:10 sbrunner