prospector icon indicating copy to clipboard operation
prospector copied to clipboard

[BUG] ignore-path is ignored when using explicit_file_mode

Open flobz opened this issue 3 years ago • 2 comments
trafficstars

Describe the bug The ignore-path config is ignored when using explicit file node. This is annoying when prospector is started from a pre-commit hook.

To Reproduce Steps to reproduce the behavior:

  1. add "tests" to ignore-paths' in .prospector.yaml
  2. call prospector tests/XXX.py

Expected behavior Ignore tests/XXXX/py

Environment (please complete the following information):

  • OS: Linux
  • Prospector 1.7.7
  • Python version [e.g. 3.7.12]

I could provide a fix if this behavior is unintentional.

flobz avatar Mar 28 '22 21:03 flobz

Could you try with 1.8.0rc1 ? The 1.8 release contains a big rewrite of finding files and deciding which ones to check, it hopefully will have also fixed this (though not intentionally).

carlio avatar Mar 28 '22 22:03 carlio

1.8.0rc1 seem to fix this issue.

flobz avatar Mar 29 '22 19:03 flobz

Is 1.8.0rc1 available somewhere readily packaged or would one need to checkout the tag and install from source?

okuuva avatar Nov 03 '22 07:11 okuuva

https://pypi.org/project/prospector/1.8.0rc1/ you can install rc version with the --pre option of pip

Pierre-Sassoulas avatar Nov 04 '22 10:11 Pierre-Sassoulas