prospector icon indicating copy to clipboard operation
prospector copied to clipboard

Add support for Flake8

Open Peilonrayz opened this issue 6 years ago • 4 comments

Is this something that would be wanted, or not wanted?


From my very nooby POV I can see:

Pros:

  • One tool to rule them all.
  • Adds support for Flake8 plugins without having to add custom code to tools.

Cons:

  • Tools available in both Prospector and Flake8 may run twice, potentially with different configurations.

Peilonrayz avatar Mar 28 '19 18:03 Peilonrayz

I would be very pleased by this feature: https://github.com/wemake-services/wemake-python-styleguide/issues/624

With it I can easily integrate wemake-python-styleguide with prospector.

sobolevn avatar Jul 03 '19 07:07 sobolevn

Messages can be merged to avoid duplicate warning/error messages. Feel like trying to implement it? We welcome PRs.

chocoelho avatar Jul 21 '19 15:07 chocoelho

Before moving on with this, we'll need to up the supported version of pyflakes to <2.2.0 as it's currently in their own setup configuration (Flake8).

chocoelho avatar Aug 31 '19 17:08 chocoelho

Also, some other tools, such as pycodestyle might require some tweak as per this setup.cfg file from Flake8 mentioned above.

chocoelho avatar Aug 31 '19 17:08 chocoelho