isort icon indicating copy to clipboard operation
isort copied to clipboard

Update stage names for `pre-commit`

Open matthewhughes934 opened this issue 1 year ago • 1 comments

pre-commit v4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimum pre-commit version to one that supports the new names

See also[2] for a similar change and the docs[3].

[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05 [2] https://github.com/pre-commit/pre-commit-hooks/commit/003dfa55c9eb05b08b33f60864363392958f4618 [3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

Fixes: https://github.com/PyCQA/isort/issues/2294

matthewhughes934 avatar Oct 10 '24 07:10 matthewhughes934

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.15%. Comparing base (7de1829) to head (4eeb37a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2296   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          39       39           
  Lines        3091     3091           
  Branches      748      748           
=======================================
  Hits         3065     3065           
  Misses         15       15           
  Partials       11       11           

codecov[bot] avatar Oct 10 '24 07:10 codecov[bot]

Could you please rebase/merge main to check if this would fix security checks

eirnym avatar Nov 26 '24 11:11 eirnym

Could you please rebase/merge main to check if this would fix security checks

The branch looks to be up to date with main: commit 4eeb37a8cda544171d223c00b4729eaefd1528b6 is on top of the current tip of main (though the last commit on main was ~10 months ago)

$ git log --max-count=2 --format='%H %s'
4eeb37a8cda544171d223c00b4729eaefd1528b6 Update stage names for `pre-commit`
7de182933fd50e04a7c47cc8be75a6547754b19c Merge pull request #2223 from PyCQA/dependabot/pip/gitpython-3.1.41

matthewhughes934 avatar Nov 26 '24 11:11 matthewhughes934

It's sad to see security check failing because of vulnerable main branch. I had a little bit of hope that this would fix failing job.

eirnym avatar Nov 26 '24 12:11 eirnym

When will this be merged and released?

BaseMax avatar Jan 06 '25 19:01 BaseMax

I juts rebased on main + force push to bring in changes that should make all the checks green :crossed_fingers:

matthewhughes934 avatar Jan 09 '25 09:01 matthewhughes934

Thanks

BaseMax avatar Jan 09 '25 21:01 BaseMax