autoflake icon indicating copy to clipboard operation
autoflake copied to clipboard

default to running with `--in-place` in pre-commit hook

Open graingert opened this issue 5 years ago • 2 comments
trafficstars

graingert avatar Sep 20 '20 09:09 graingert

At the very least the hook should pass -c argument so that you get notified of issues.

The current behaviour of the hook without arguments is that it always prints:

autoflake................................................................Passed

Which is not very helpful :-)

But I'd also prefer defaulting to --in-place - given the tool is about automatically making changes. If I just want notifications, then I can use flake8 as a commit hook.

spookylukey avatar Sep 18 '21 20:09 spookylukey

Agree — would it be reasonable to have the suggested entry at https://github.com/myint/autoflake/pull/62#issue-552588261 be the default?

max-sixty avatar Jan 11 '22 12:01 max-sixty