awesomeScripts icon indicating copy to clipboard operation
awesomeScripts copied to clipboard

Added a script to download subtitles from podnapsi Fixes #401

Open afro-coder opened this issue 4 years ago • 3 comments

Pull Request Template

script name - subtitles_downloader_script/

What have you Changed Added a script to download subtitles as mentioned in #401

what you changed in the codebase.write here Added a folder subtitles_downloader_script/

Issue no.(must) - #401

Self Check(Tick After Making pull Request)

  • [x] This issue was assigned to me.
  • [x] One Change in one Pull Request
  • [x] My file is in proper folder
  • [x] I am following clean code and Documentation and my code is well linted with flake8.
  • [x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Join Us on Discord:- https://discord.gg/JfbK3bS

acknowledgement

  • [x] I have tested the script and distributing it under MIT license.

afro-coder avatar Oct 18 '21 05:10 afro-coder

Is there any specific version of the linter that is required? I'm not seeing any linting issues on my end

$ /home/leon/.local/bin/flake8 subtitles_downloader_script/subdw.py
$ echo $?
0

afro-coder avatar Oct 22 '21 15:10 afro-coder

we are using latest version on flake8

Screenshot 2021-10-24 101301

codeperfectplus avatar Oct 24 '21 04:10 codeperfectplus

Oh which version is that

/home/leon/.local/bin/flake8 --version
4.0.1 (mccabe: 0.6.1, pycodestyle: 2.8.0, pyflakes: 2.4.0) CPython 3.9.7 on Linux

I have this one.

afro-coder avatar Oct 24 '21 13:10 afro-coder