code-d icon indicating copy to clipboard operation
code-d copied to clipboard

"Search in dpldocs" is taking forever

Open brianush1 opened this issue 4 years ago • 8 comments

brianush1 avatar Mar 21 '21 23:03 brianush1

For me, only the title is shown, nothing else.

benoit-dubreuil avatar Jul 08 '21 16:07 benoit-dubreuil

for me the search returns results in an acceptable amount of time. It only showing title as well as #333 is fixed in ~master now

do you have many dependencies in your project? It will search the dpldocs for every dependency you have as well and show the loading bar for that time. However when it finds partial results it will show them early while still showing the loading bar.

WebFreak001 avatar Jul 11 '21 17:07 WebFreak001

note btw that the dpldocs.info/term thing does a cross-package search itself now

adamdruppe avatar Jul 11 '21 18:07 adamdruppe

I know of all the dependencies the user has, I think it's a better user experience to only show documentation for the packages, the user already includes.

WebFreak001 avatar Jul 12 '21 06:07 WebFreak001

This seems to take literally forever, such that I believe it's not working. As someone rusty in D (haven't used it much in about 10 years), I tried right-clicking keyword final and clicking "Search in dpldocs" which looked like a convenient way to read about it. However, code-d got stuck on "Looking up documentation" for more than 10 minutes with no end in sight.

It's possible I'm misunderstanding the intended use case of this context menu entry though. I expected it to look up the symbol that I right-clicked on.

AlexFolland avatar May 08 '22 21:05 AlexFolland

OK, I think I get why it failed. https://search.dpldocs.info/?q=final shows no results.

AlexFolland avatar May 08 '22 21:05 AlexFolland

On Sun, May 08, 2022 at 02:32:19PM -0700, Alex Folland wrote:

OK, I think I get why it failed. https://search.dpldocs.info/?q=final shows no results.

dpldocs looks up functions or classes, etc, rather than language keywords....

adamdruppe avatar May 08 '22 21:05 adamdruppe

There seems to be at least a couple of issues here with code-d then.

  • That context menu entry should not be present on language keywords.
  • When the search returns with 0 results, code-d should say so and end the search instead of leaving the user hanging, wondering what's happening.

AlexFolland avatar May 08 '22 21:05 AlexFolland