Adam Warner

Results 244 comments of Adam Warner
trafficstars

Are the minors and patches not rolled into the v3 action? I've never seen an example workflow use the full version number...

👀 - and that's not even the latest version!

Just throwing [this](https://docs.github.com/en/actions/creating-actions/about-custom-actions#versioning-your-action:~:text=Instead%2C%20you%20can%20recommend%20that%20your%20users%20specify%20a%20major%20version%20when%20using%20your%20action%2C%20and%20only%20direct%20them%20to%20a%20more%20specific%20version%20if%20they%20encounter%20issues.) in here. Like Is said, I've never seen any docs point to using an exact version before - upstream actions owners should be moving the `v2`/`v3` etc...

It appears only `stale` has not done this. ![image](https://user-images.githubusercontent.com/1998970/180729154-f951db99-0a72-4abe-8aec-e8d11a3a74ed.png) ![image](https://user-images.githubusercontent.com/1998970/180729180-cb3a8104-eb43-48de-b898-cc263a9bbbf5.png) ![image](https://user-images.githubusercontent.com/1998970/180729303-0fe0b411-47dc-454c-95ee-b077298fd3b9.png)

You might just have convinced me. I notice you have set everything to `x.0.0`, is that to test the dependabot action? Might be safer to set it off on a...

`custom.php` support has been there forever, I don't know how many people actually use it. I also realised that the "did you mean to go to the admin page" thing...

> still there? Are they needed? Possibly missed it. I will give it a second pass :)

I will try and give this another look over tomorrow with the changes added - just a reminder that it will probably need a bit of squashing!

Hi, thanks for the submission. > It tries to save bandwith by avoiding unneccessary downloads I'll be honest, this is not a problem I've noticed personally, and wonder if this...