whisky
whisky copied to clipboard
ProjektGopher
Drop Support for PHP8.1
Thx man. I'll probably cherry pick the commits for the gh actions version bumps, add in a pull-request trigger for the actions since they don't seem to be running, and put that in a separate pr.
Since 8.1 is still getting security updates I'd prefer to keep that in our testing matrix unless L11 is the blocker for that. If that's the case, I might hold off on bumping our laravel dep until 8.1 is eol.
What are your thoughts, @gpibarra?
Yes, Laravel 11 is only compatible with PHP 8.2. The change to Laravel 11 implies that the new phar will be built with Laravel11 and can only be run with php8.2. However, if someone tries to install via composer (local or global) with a version of php 8.1 then whisky will be installed with the version prior to this change. This implies that the new features will only be available for the latest version of php8.2. Otherwise, the latest version that is compatible with php8.1 could be tagged and the new features should be made via cherry-pick in that branch... this approach implies a greater effort in maintenance... I think any decision will be fine (wait until the end of the year for the 8.1 EOF, make the changes and new features only in the new branch and optionally duplicate new features in the old branch).
I think I'm going to go ahead and close this PR for now. I'd like to keep 8.1 support at least until I'm finally ready to tag 1.0 stable since it's still going to receive security updates for another years now.
If we eventually need L11 for some killer new feature then maybe we can think about bumping our PHP version again, but right now I don't think there's any super new feature we need from the framework.
Thx again, @gpibarra for the other commits that I was able to cherry-pick!