osrm-frontend icon indicating copy to clipboard operation
osrm-frontend copied to clipboard

Integrate icon for French translation

Open TheMarex opened this issue 9 years ago β€’ 7 comments

#177 added French translations, this is not integrated into the frontend yet ~~since it is missing an icon to select the language.~~

This needs to be integrated in the menu displayed on project-osrm.org

TheMarex avatar Jun 20 '16 16:06 TheMarex

Thanx ! I thought you might already have a flag to include in flags.svg. I'm really eager to have French directions :-)

ymoisan avatar Jun 21 '16 20:06 ymoisan

See 3892090 for a French flag in SVG format.

ymoisan avatar Jun 22 '16 14:06 ymoisan

The SVG for the French flag needs to be added here: https://github.com/Project-OSRM/osrm-frontend/blob/gh-pages/images/osrm.toolbar.icons.svg and then minor changes to the code to get it to work.

@bhousel ^ do you think you maybe able to help? I know nothing about Inkscape and SVG sprite generation - but if you can get the flag in there, I can take it from there. Thanks!

batpad avatar Jan 17 '17 11:01 batpad

Flagging (heh): same needs to be done for all languages here still missing from the icons.

daniel-j-h avatar Jan 17 '17 12:01 daniel-j-h

cc @ajithranka

batpad avatar Jan 18 '17 05:01 batpad

French is on place after implementing select-based language chooser (#228)

yuryleb avatar Apr 22 '17 21:04 yuryleb

The flags are no longer used after #214, correct? Can we safely delete πŸ‡ΊπŸ‡Έ and πŸ‡©πŸ‡ͺ from osrm.toolbar.icons.svg?

1ec5 avatar May 04 '17 15:05 1ec5