osrm-backend icon indicating copy to clipboard operation
osrm-backend copied to clipboard

uncomment "cyclability" weight name

Open szymon-szym opened this issue 1 year ago • 3 comments

Issue

It looks like in profile/bicycle.lua the weight_name in properties was unintentionally commented out

Without it set to cyclability the safety_check is committed when using this profile. Turns' weights are also calculated differently

Tasklist

Requirements / Relations

szymon-szym avatar Sep 29 '24 10:09 szymon-szym

From the introduction of the concept weight in bicycle profile, it always be duration as default.

https://github.com/Project-OSRM/osrm-backend/commit/279f8aabfb#diff-c4b120b8978b0193746a4accb230bf085b89bca0fdda9f17920e056ddaee820fR58

I see this PR as a possible breaking change.

Nevertheless can can still use cyclability on you side if you prefer it.

frodrigo avatar Oct 01 '24 13:10 frodrigo

This PR seems to be stale. Is it still relevant?

github-actions[bot] avatar Mar 31 '25 02:03 github-actions[bot]

For context: This was not chosen as the default because it roughly x1.5 the memory usage since you need separate weight and duration values.

TheMarex avatar Oct 02 '25 12:10 TheMarex