Progi1984

Results 412 comments of Progi1984

@Garrcomm Hi, thank you for your contribution. Could you rebase your PR for fixing conflicting files ? or can I integrate your modifications in another PR ?

@ophian I fixed it and rebase the PR.

@wisskid I just fixed tests. Thanks ![image](https://user-images.githubusercontent.com/1533248/187621654-e39063c1-dcbb-4334-a89a-f922403e7550.png)

Hi @wisskid, have you some time to restart the CI, please ?

@wisskid The CI is fixed. I checked PHPUnit on PHP 8.2 RC / PHP 8.1 / PHP 8.0 / PHP 7.4 / PHP 7.3 / PHP 7.2 : https://github.com/Progi1984/smarty/actions/runs/3060762059 The...

@ophian Of course, in PHP 8.2, `Smarty_Variable` becomes `\Smarty_Variable` in `var_export` of the variable. So the regex didn't work. I check the change (`ENT_COMPAT` => `ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401`)...

Hi @wisskid, have you some time to restart the CI, please ?

Thanks for the CI @wisskid : it's :green_circle:

Hi @wisskid, have you some time to review this PR, please ? Thanks for your time.

Hi @NoUseFreak, How is it possible to launch static methods from a job ?