processmaker icon indicating copy to clipboard operation
processmaker copied to clipboard

FOUR-13976: Web entry link not redirecting to the screen when using default SSO SAML authentication

Open pmPaulis opened this issue 7 months ago • 15 comments

Issue & Reproduction Steps

Web entry link not redirecting to the screen when using default SSO SAML authentication

Solution

  • List the changes you've introduced to solve the issue.

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

-https://processmaker.atlassian.net/browse/FOUR-13976

Code Review Checklist

  • [ ] I have pulled this code locally and tested it on my instance, along with any associated packages.
  • [ ] This code adheres to ProcessMaker Coding Guidelines.
  • [ ] This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • [ ] This solution fixes the bug reported in the original ticket.
  • [ ] This solution does not alter the expected output of a component in a way that would break existing Processes.
  • [ ] This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • [ ] This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • [ ] This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • [ ] This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

pmPaulis avatar Apr 14 '25 23:04 pmPaulis

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

/opt/pishrobpms/ProcessMaker/Traits/TaskControllerIndexMethods.php: $processableUser = DB::table('processables')->where([ 'processable_type' => User::class, 'processable_id' => $user->id, 'method' => 'EDIT_DATA', ])->pluck('process_id')->toArray();

Good time, According to this path, when we assign a person to edit the data of a process and then delete it, that person can still view the requests for that process even though they no longer have access, therefore the "null version" condition should also be checked in this section code.

programerboy avatar Apr 15 '25 06:04 programerboy

Another problem: In version 3 we could specify a process supervisor and this user had access to the data of the requests of that process for review or reallocation. However, in version 4 this feature is not well seen and the user must first have access to "view all requests" and then have access to "edit data" in the process settings section and this will cause him to see other requests related to other processes, which is not correct!

programerboy avatar Apr 15 '25 07:04 programerboy

https://ci-a875223217.engk8s.processmaker.net/login

pmPaulis avatar Apr 15 '25 13:04 pmPaulis

@marcoAntonioNina I found a problem with this change image I'm reviewing this issue, if is related with mi changes or config in SAML Regards,

pmPaulis avatar Apr 17 '25 16:04 pmPaulis

Hello @pmPaulis was the issue mentioned above ever resolved?

ryancooley avatar May 21 '25 08:05 ryancooley

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 21 '25 09:05 vladyrichter

@ryancooley Nop yet, I was focussed in other priorizations. I will review with Roly that is in maintenances this Sprint. Regards, cc @boliviacoca @gproly

pmPaulis avatar May 21 '25 12:05 pmPaulis

For your reference: https://processmaker.atlassian.net/browse/FOUR-13976

boliviacoca avatar May 21 '25 13:05 boliviacoca

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 21 '25 15:05 vladyrichter

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 21 '25 18:05 vladyrichter

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 21 '25 22:05 vladyrichter

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 22 '25 03:05 vladyrichter

QA server K8S was successfully deployed https://ci-a875223217.engk8s.processmaker.net

vladyrichter avatar May 22 '25 17:05 vladyrichter

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube