OpenHack
OpenHack copied to clipboard
[Bug] accurate percentage messes with platformer time when turned off
Describe the bug & reproduce when having the mod enabled and having accurate percentage off, and having another mod enabled Formatted Platformer Time, the platformer timer has it's vanilla behavior instead formatted platformer time's behavior. (it's format looks subjectively better to me and doesn't change the time after dying)
a fix fix it messing with the timer when accurate percentage is off, and add a option in accurate percentage to disable the platformer changes and only have the classic mode ones.
side note I would have tried to fix this bug on my own but I can't seem to get it to compile on linux. (other mods compile fine but not this one) (linux cross mod compiling)
build error log
[ 27%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/animation/move_action.cpp.obj
[ 27%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/gui.cpp.obj
[ 28%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/modal.cpp.obj
[ 28%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/themes/classic/classic.cpp.obj
[ 29%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/themes/gruvbox/gruvbox.cpp.obj
[ 29%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/themes/megahack/megahack.cpp.obj
[ 30%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/themes/modern/modern.cpp.obj
[ 30%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/themes/themes.cpp.obj
[ 31%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/gui/window.cpp.obj
[ 31%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/accurate-percentage/accurate-percentage.cpp.obj
[ 32%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/auto-deafen/auto-deafen.cpp.obj
[ 32%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/auto-kill/auto-kill.cpp.obj
[ 33%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/auto-pickup-coins/auto-pickup-coins.cpp.obj
[ 33%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/auto-safemode/auto-safemode.cpp.obj
[ 34%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/auto-save/auto-save.cpp.obj
[ 34%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/click-tp/click-tp.cpp.obj
[ 35%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/custom-wave-trail/custom-wave-trail.cpp.obj
[ 35%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/discord-rpc/discord-rpc.cpp.obj
[ 36%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/display/display.cpp.obj
[ 36%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/frame-stepper/frame-stepper.cpp.obj
[ 37%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/hacks.cpp.obj
[ 37%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/hide-pause/hide-pause.cpp.obj
[ 38%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/hide-triggers/hide-triggers.cpp.obj
[ 38%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/hitboxes/hitboxes.cpp.obj
[ 39%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/instant-complete/instant-complete.cpp.obj
[ 39%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/labels/label.cpp.obj
[ 40%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/labels/labels.cpp.obj
[ 40%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/menu-gameplay/menu-gameplay.cpp.obj
[ 41%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/noclip-limit/noclip-limit.cpp.obj
[ 41%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/random-seed/random-seed.cpp.obj
[ 42%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/respawn-delay/respawn-delay.cpp.obj
[ 42%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/rgb-icons/rgb-icons.cpp.obj
[ 43%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/shortcuts/shortcuts.cpp.obj
[ 43%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/smart-startpos/smart-startpos.cpp.obj
[ 44%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/speedhack/speedhack.cpp.obj
[ 44%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/startpos-switcher/startpos-switcher.cpp.obj
[ 45%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/zephyrus/replays.cpp.obj
[ 45%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/menu/blur.cpp.obj
[ 46%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/menu/keybinds.cpp.obj
[ 46%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/menu/menu.cpp.obj
[ 47%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/shared/openhack.cpp.obj
[ 47%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/CCDrawNode.cpp.obj
[ 48%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/CCScheduler.cpp.obj
[ 48%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/ChannelControl.cpp.obj
[ 49%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/EditorUI.cpp.obj
[ 49%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/GJBaseGameLayer.cpp.obj
[ 50%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/GameStatsManager.cpp.obj
[ 50%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/HardStreak.cpp.obj
[ 51%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/LevelEditorLayer.cpp.obj
[ 51%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/MainGameLayer.cpp.obj
[ 52%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/MenuLayer.cpp.obj
[ 52%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/PauseLayer.cpp.obj
[ 53%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/PlayLayer.cpp.obj
[ 53%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/hooks/PlayerObject.cpp.obj
[ 54%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/main.cpp.obj
[ 54%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/pch.cpp.obj
[ 55%] Building CXX object CMakeFiles/OpenHack-Geode.dir/src/geode/utils.cpp.obj
[ 56%] Building CXX object CMakeFiles/OpenHack-Geode.dir/libs/imgui-cocos/src/backend.cpp.obj
[ 56%] Building CXX object CMakeFiles/OpenHack-Geode.dir/libs/imgui-cocos/src/hooks.cpp.obj
[ 57%] Building CXX object CMakeFiles/OpenHack-Geode.dir/home/Async/Documents/gd/geode/entry.cpp.obj
[ 57%] Linking CXX shared library prevter.openhack.dll
LINK: command "/usr/bin/lld-link /nologo @CMakeFiles/OpenHack-Geode.dir/objects1.rsp /out:prevter.openhack.dll /implib:prevter.openhack.lib /pdb:/home/Async/Documents/gd/gdopenhack/build/prevter.openhack.pdb /dll /version:0.0 -libpath:/home/Async/xwin-0.5.1-x86_64-unknown-linux-musl/splat//crt/lib/x86 -libpath:/home/Async/xwin-0.5.1-x86_64-unknown-linux-musl/splat//sdk/lib/ucrt/x86 -libpath:/home/Async/xwin-0.5.1-x86_64-unknown-linux-musl/splat//sdk/lib/um/x86 -libpath:/home/Async/Documents/gd/gdopenhack/build/winsdk_lib_symlinks /INCREMENTAL:NO /DEF:CMakeFiles/OpenHack-Geode.dir/exports.def -LIBPATH:/home/Async/Documents/gd/geode/loader/include/link user32.lib kernel32.lib shell32.lib ole32.lib crypt32.lib advapi32.lib delayimp.lib gdi32.lib user32.lib kernel32.lib shell32.lib ole32.lib crypt32.lib advapi32.lib delayimp.lib gdi32.lib libs/imgui.lib libs/glfw/src/glfw3.lib /home/Async/Documents/gd/gdopenhack/libs/gd.hpp/libs/fmod.lib libs/discord-rpc/src/discord-rpc.lib psapi.lib libs/zephyrus/Zephyrus.lib /home/Async/Documents/gd/gdopenhack/libs/glew/lib/Release/Win32/glew32.lib /home/Async/Documents/gd/geode/loader/include/link/libcocos2d.lib /home/Async/Documents/gd/geode/loader/include/link/libExtensions.lib /home/Async/Documents/gd/geode/loader/include/link/libcurl.lib /home/Async/Documents/gd/geode/loader/include/link/glew32.lib /home/Async/Documents/gd/geode/loader/include/link/gdstring.lib /home/Async/Documents/gd/geode/loader/include/link/fmod.lib opengl32.lib bindings/GeodeBindings.lib _deps/fmt-build/fmt.lib geode/GeodeFilesystemImpl.lib user32.lib kernel32.lib shell32.lib ole32.lib crypt32.lib advapi32.lib gdi32.lib user32.lib kernel32.lib shell32.lib ole32.lib crypt32.lib advapi32.lib gdi32.lib delayimp.lib /home/Async/Documents/gd/geode/bin/2.0.0/Geode.lib /MANIFEST:EMBED,ID=2" failed (exit code 1) with the following output:
lld-link: error: <root>: undefined symbol: ____local_stdio_printf_options
lld-link: error: <root>: undefined symbol: ____local_stdio_scanf_options
lld-link: error: <root>: undefined symbol: __sprintf
lld-link: error: <root>: undefined symbol: __sscanf_s
lld-link: error: undefined symbol: __declspec(dllimport) _GetOpenFileNameA@4
>>> referenced by CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/shortcuts/shortcuts.cpp.obj:(void __cdecl openhack::win32::promptDllInjection(void))
>>> referenced by CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/zephyrus/replays.cpp.obj:(private: virtual void __thiscall std::_Func_impl_no_alloc<class `public: virtual void __thiscall openhack::hacks::Zephyrus::onInit(void)'::`1'::<lambda_4>, void>::_Do_call(void))
lld-link: error: undefined symbol: __declspec(dllimport) _GetSaveFileNameA@4
>>> referenced by CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/zephyrus/replays.cpp.obj:(private: virtual void __thiscall std::_Func_impl_no_alloc<class `public: virtual void __thiscall openhack::hacks::Zephyrus::onInit(void)'::`1'::<lambda_4>, void>::_Do_call(void))
>>> referenced by CMakeFiles/OpenHack-Geode.dir/src/shared/hacks/zephyrus/replays.cpp.obj:(private: virtual void __thiscall std::_Func_impl_no_alloc<class `public: virtual void __thiscall openhack::hacks::Zephyrus::onInit(void)'::`1'::<lambda_4>, void>::_Do_call(void))
make[2]: *** [CMakeFiles/OpenHack-Geode.dir/build.make:1252: prevter.openhack.dll] Error 255
make[1]: *** [CMakeFiles/Makefile2:484: CMakeFiles/OpenHack-Geode.dir/all] Error 2
make: *** [Makefile:124: all] Error 2