[Enhancement]: Modernize game-specific protocol extensions

[JPeisach]

trafficstars

Checked Existing

• [X] I have checked the repository for duplicate issues.

What enhancement would you like to see?

Some game server protocol extensions (for example, Splatoon), are not as modernized with the rest of the codebase.

For example, creating a Ranking protocol is normally handled like this:

func NewProtocol() *Protocol {
	return &Protocol{}
}

However, the Splatoon ranking protocol extension still requires the protocol to be made with the endpoint:

// NewProtocol returns a new RankingSplatoon protocol
func NewProtocol(endpoint nex.EndpointInterface) *Protocol {
	protocol := &Protocol{endpoint: endpoint}
	protocol.rankingProtocol.SetEndpoint(endpoint)

	return protocol
}

Mario Kart 8's ranking also has this:

// NewProtocol returns a new RankingMarioKart8 protocol
func NewProtocol(endpoint nex.EndpointInterface) *Protocol {
	protocol := &Protocol{endpoint: endpoint}
	protocol.rankingProtocol.SetEndpoint(endpoint)

	return protocol
}

The game-specific protocol extensions should be updated for consistency.

Any other details to share? (OPTIONAL)

No response

[JPeisach]

I should mention that Jon said that he wants game-specific protocols to be moved out of this library though?

[jonbarrow]

Closing since we decided internally to remove game-specific protocols from this package