Prajith

Results 57 comments of Prajith

> @Prajithp I'd prefer to remove the backlog selection filters until we have a test case which uses them. We shouldn't imply this stuff is supported and tested. @robholland So,...

@robholland Can you please review?

> On this again today, please can you `go mod tidy`, `go mod vendor` and commit those so that the KEDA CI system will run. Done @robholland @JorTurFer Can you...

> The scale out test fails for me locally: > > ``` > temporal_test.go:268: > Error Trace: /Users/robholland/Developer/github.com/kedacore/keda/tests/scalers/temporal/temporal_test.go:268 > /Users/robholland/Developer/github.com/kedacore/keda/tests/scalers/temporal/temporal_test.go:241 > Error: Should be true > Test: TestTemporalScaler > Messages:...

> The tests are failing on CI, those should be fixed before its marked for review. It should be fine now.

> Cool, @Prajithp wanna mark as ready for review now? Yes. Can you please review? @jhecking @zroubalik

@zroubalik Can you please review this?