PowerShellEditorServices icon indicating copy to clipboard operation
PowerShellEditorServices copied to clipboard

VIM E2E Test Broken by VIM Ubuntu Package 8.2.3995-1ubuntu2.19

Open JustinGrote opened this issue 1 year ago • 5 comments

https://github.com/PowerShell/PowerShellEditorServices/actions/runs/11132769096/job/30937371296?pr=2152

JustinGrote avatar Oct 02 '24 00:10 JustinGrote

Test works fine in upterm, weird. What context is different in the run env I wonder? image

JustinGrote avatar Oct 02 '24 00:10 JustinGrote

@andyleejordan I think whatever VIM you're downloading, something in the latest version broke the tests. If I remove the ENV to the executable, the test completes, see this PR: https://github.com/PowerShell/PowerShellEditorServices/pull/2183

JustinGrote avatar Oct 02 '24 00:10 JustinGrote

Looks like package updated to vim-gtk3 8.2.3995-1ubuntu2.19, it was ubuntu2.18 before, something in that update appears to have broken it. https://launchpad.net/ubuntu/+source/vim/2:8.2.3995-1ubuntu2.19

JustinGrote avatar Oct 02 '24 00:10 JustinGrote

@andyleejordan nightly works fine, so I adjusted the github action to use nightly, see this PR: https://github.com/PowerShell/PowerShellEditorServices/pull/2183

We will need to actually verify if the extension is actually broken due to this security update package, since it is the current stable ubuntu package and will have widespread usage, and determine if it's something with us or with vim or their lsp client (it's not clear from the test)

JustinGrote avatar Oct 02 '24 01:10 JustinGrote

Yay for fun new bugs.

andyleejordan avatar Oct 07 '24 22:10 andyleejordan