PowerShellEditorServices icon indicating copy to clipboard operation
PowerShellEditorServices copied to clipboard

Request: Bump MEC and MEL to at least 2.2.0

Open JustinGrote opened this issue 4 years ago • 3 comments

Hello,

PSES on Win5.1 loads 2.0.0.0 assembly of Microsoft.Extensions.Configuration. Most non-MS config extensions (YAML, TOML) require at least 2.2.0.0 so my PowerConfig module will not work when running in a PSES context on Win5.1 (works fine on 7 because it's abstracted into an ALC).

Any chance a bump to 2.2 would be possible?

JustinGrote avatar Jun 08 '21 05:06 JustinGrote

@JustinGrote Do you know if it's guaranteed that these versions of these two libraries exist wherever PowerShell 5.1 exists? We don't explicitly declare either of these dependencies, but they are required by OmniSharp at 2.0.0.0, so if we were to update underneath it we would have to test for compatibility. Might I suggest opening an issue with OmniSharp to get them updated and tested for compatibility, and then we can update our OmniSharp dependency.

andyleejordan avatar Jun 14 '21 21:06 andyleejordan

@andschwa the libraries aren't part of Powershell 5.1, they are loaded by PSES and because PSES in PS5.1 can't use AssemblyLoadContexts, they "pollute" the main runspace.

JustinGrote avatar Jun 14 '21 21:06 JustinGrote

TBH the first part of my question was no longer relevant once we realized OmniSharp was bringing them along, sorry 🤷 I only just was able to make my coffee for the day.

andyleejordan avatar Jun 14 '21 22:06 andyleejordan