Fix completion crash for the SCCM provider

[MartinGC94]

PR Summary

Supersedes https://github.com/PowerShell/PowerShell/pull/20815 and actually fixes the issue this time:

It turns out that the SCCM provider returns the items as strings and adds all the various PS* properties as NoteProperties and none of the PS* properties include the actual value, see:

PR Context

Fixes https://github.com/PowerShell/PowerShell/issues/20803 (for real this time)

PR Checklist

• [X] PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• [X] Summarized changes
• [X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• [X] This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • [X] None
  • OR
  • [ ] Experimental feature(s) needed
    • [ ] Experimental feature name(s):
• User-facing changes
  • [X] Not Applicable
  • OR
  • [ ] Documentation needed
    • [ ] Issue filed:
• Testing - New and feature
  • [X] N/A or can only be tested interactively
  • OR
  • [ ] Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • [X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • [ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • [ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • [ ] Issue filed:
    • [ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • [ ] Issue filed:
    • [ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • [ ] Issue filed:
    • [ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • [ ] Issue filed:

[daxian-dbw]

@MartinGC94 https://github.com/PowerShell/PowerShell/pull/20815 was already merged, can you please rebase this PR against the master branch, so it's easier to see the changes on top?

[daxian-dbw]

@MartinGC94 Thanks for rebasing. A question before moving on to review the code: are the changes from #20815 still relevant? I assume those changes are relevant to the fix and should be kept but want you to confirm.

[MartinGC94]

@daxian-dbw They are not. I tried reverting them with https://github.com/PowerShell/PowerShell/pull/20915/commits/ab72ca78f2f5b0c7310e9510dde74b1f958b5bed but I don't see that in the changes overview https://github.com/PowerShell/PowerShell/pull/20915/files so I must be doing something wrong.

GitHub

Fix completion crash for the SCCM provider by MartinGC94 · Pull Request #20915 · PowerShell/PowerShell

PR Summary Supersedes #20815 and actually fixes the issue this time:

It turns out that the SCCM provider returns the items as strings and adds all the various PS* properties as NoteProperties and ...

[daxian-dbw]

They are not. I tried reverting them with https://github.com/PowerShell/PowerShell/commit/ab72ca78f2f5b0c7310e9510dde74b1f958b5bed but I don't see that in the changes overview

Thanks for confirming. I submitted the https://github.com/PowerShell/PowerShell/pull/20919 to revert them then. Once the reverting PR is merged, please rebase this one again.

[Update] The reverting PR was merged: #20919

[daxian-dbw]

@alexlarner could you please try this fix again and see if it solves the problem? Thanks!

[alexlarner]

@alexlarner could you please try this fix again and see if it solves the problem? Thanks!

Yep, that did the trick. Thanks!

[pull-request-quantifier-deprecated[bot]]

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +6 -1
Percentile : 2.8%

Total files changed: 1

Change summary by file extension:
.cs : +6 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.