PSReadLine icon indicating copy to clipboard operation
PSReadLine copied to clipboard

Some emoji, eg 'πŸ˜ƒ' don't work, whereas others like '⏰' do

Open mikemaccana opened this issue 6 years ago β€’ 29 comments

Moved from https://github.com/microsoft/terminal/issues/1606

Using app store preview build of Windows Terminal, with win+. to send πŸ˜ƒ and then ⏰:

image

@DHowett-MSFT mentioned it's likely not a Windows Terminal issue:

Powershell has trouble with high unicode input ... and there's not much we can do to help that.


Name                           Value
----                           -----
PSVersion                      6.2.1
PSEdition                      Core
GitCommitId                    6.2.1
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

mikemaccana avatar Jun 27 '19 12:06 mikemaccana

I wonder if this is due to PS itself or PSReadLine...

Can you Remove-Module PSReadline and try it again?

vexx32 avatar Jun 27 '19 12:06 vexx32

After Remove-Module PSReadline

image

mikemaccana avatar Jun 27 '19 22:06 mikemaccana

Interesting. Input doesn't like it much, but output is OK.

I'd venture to say this is probably an issue both for PS itself in places and the PSReadLine module as well,

@daxian-dbw any thoughts on this?

vexx32 avatar Jun 27 '19 23:06 vexx32

/cc @daxian-dbw @SteveL-MSFT Should we track the issue here or in PSREadline repo?

iSazonov avatar Oct 02 '19 11:10 iSazonov

Seems like there is an issue in both PS and PSRL. We can keep this issue here for now. Removing PSRL and on macOS, simply pasting "πŸ˜ƒ results in οΏ½"πŸ˜ƒοΏ½. Quite strange.

SteveL-MSFT avatar Oct 02 '19 16:10 SteveL-MSFT

@chuanjiao10 that may be true on Windows, but on macOS there is still an issue although perhaps different from the original issue

SteveL-MSFT avatar Oct 03 '19 18:10 SteveL-MSFT

In Windows Terminal, garbage characters may appear when deleting the emoji character.

daxian-dbw avatar Oct 09 '19 21:10 daxian-dbw

@daxian-dbw Is any updates in PSRL with the issue?

iSazonov avatar Jan 31 '20 10:01 iSazonov

@iSazonov Unfortunately, no news from the PSReadLine side. also, as mentioned in this issue, the same repros without PSReadLine.

daxian-dbw avatar Jan 31 '20 18:01 daxian-dbw

PSReadline uses raw input and non-PSReadline uses COOKED_READ in the console host. One of these things can never be fixed :smile:

DHowett-MSFT avatar Jan 31 '20 18:01 DHowett-MSFT

I'd prefer to get updated COOKED_READ in Core.

iSazonov avatar Jan 31 '20 18:01 iSazonov

Cooked read is provided by conhost.exe, not Core, and we cannot change it without significantly impacting application compatibility all across Windows. Raw input with a readline-like library is the correct thing to do.

DHowett-MSFT avatar Jan 31 '20 18:01 DHowett-MSFT

Raw input with a readline-like library is the correct thing to do.

I mean that this must be in Core so that we do not re-implement this in every application. Is there a tracking issue?

iSazonov avatar Jan 31 '20 18:01 iSazonov

@iSazonov - see https://github.com/PowerShell/PSReadLine/issues/1045

lzybkr avatar Jan 31 '20 20:01 lzybkr

I opened https://github.com/dotnet/runtime/issues/800, maybe not entirely correct, but the presence of these features in Core seems desirable.

iSazonov avatar Feb 01 '20 08:02 iSazonov

@DHowett-MSFT You mentioned in microsoft/terminal#1606 that:

Powershell has trouble with high unicode input ... and there's not much we can do to help that.

For all high unicode emoji input, such as πŸ˜€ (surrogates: D83D, DE04), Console.Readkey() seems to only return a high surrogates character, like ConsoleKeyInfo { Key = 18, KeyChar = '\ud83d', Modifiers = 0 }, but not the low surrogates. Could you please provide me some pointers on how to correctly read all surrogates? An in general, can you please provide me some pointers on how should a readline library handle emojis?

daxian-dbw avatar May 19 '20 21:05 daxian-dbw

@daxian-dbw it's sent as two separate keys. If you do this you'll see both

while ($true) {
    '0x{0:X4}' -f [int][Console]::ReadKey($true).KeyChar
}

SeeminglyScience avatar May 19 '20 22:05 SeeminglyScience

Also, I think escape sequences are being written between the surrogates:

[Console]::WriteLine("`u{D83D}`u{DE00}")
# Shows emoji

[Console]::WriteLine("`u{D83D}`e[30m`u{DE00}")
# Shows two separate question mark characters

SeeminglyScience avatar May 19 '20 23:05 SeeminglyScience

[Console]::WriteLine("u{D83D}u{DE00}") shows 2 question mark character for me in both Windows terminal and legacy console host:

image

daxian-dbw avatar May 19 '20 23:05 daxian-dbw

Yeah you gotta change output encoding first:

[Console]::OutputEncoding = [Text.Encoding]::Unicode

SeeminglyScience avatar May 19 '20 23:05 SeeminglyScience

Oh, is it a time to change [Console]::OutputEncoding to Utf8 for PowerShell?

iSazonov avatar May 20 '20 03:05 iSazonov

Also Delete should delete two characters if the target is a high surrogate. @daxian-dbw let me know if you want a new issue for that.

SeeminglyScience avatar Jun 05 '20 14:06 SeeminglyScience

@SeeminglyScience Yes, please open a new issue for Delete. Thanks!

daxian-dbw avatar Jun 05 '20 14:06 daxian-dbw

For me later: https://github.com/microsoft/terminal/issues/1503#issuecomment-605311026

daxian-dbw avatar Jun 10 '20 00:06 daxian-dbw

I've got also an Exception for a πŸ’„in my commit message.

Exception:

System.Text.EncoderFallbackException: Unable to translate Unicode character \\uD83D at index 10 to specified code page.
   at System.Text.EncoderExceptionFallbackBuffer.Fallback(Char charUnknown, Int32 index)
   at System.Text.EncoderFallbackBuffer.InternalFallback(ReadOnlySpan`1 chars, Int32& charsConsumed)
   at System.Text.Encoding.GetBytesWithFallback(ReadOnlySpan`1 chars, Int32 originalCharsLength, Span`1 bytes, Int32 originalBytesLength, EncoderNLS encoder)
   at System.Text.Encoding.GetBytesWithFallback(Char* pOriginalChars, Int32 originalCharCount, Byte* pOriginalBytes, Int32 originalByteCount, Int32 charsConsumedSoFar, Int32 bytesWrittenSoFar, EncoderNLS encoder)
   at System.Text.Encoding.GetBytes(Char* pChars, Int32 charCount, Byte* pBytes, Int32 byteCount, EncoderNLS encoder)
   at System.Text.EncoderNLS.GetBytes(Char[] chars, Int32 charIndex, Int32 charCount, Byte[] bytes, Int32 byteIndex, Boolean flush)
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.IO.StreamWriter.Dispose(Boolean disposing)
   at System.IO.TextWriter.Dispose()
   at Microsoft.PowerShell.PSConsoleReadLine.<>c__DisplayClass81_0.<WriteHistoryRange>b__0()
   at Microsoft.PowerShell.PSConsoleReadLine.WithHistoryFileMutexDo(Int32 timeout, Action action)
   at Microsoft.PowerShell.PSConsoleReadLine.WriteHistoryRange(Int32 start, Int32 end, Func`2 fileOpener)
   at Microsoft.PowerShell.PSConsoleReadLine.IncrementalHistoryWrite()
   at Microsoft.PowerShell.PSConsoleReadLine.MaybeAddToHistory(String result, List`1 edits, Int32 undoEditIndex, Boolean fromDifferentSession, Boolean fromInitialRead)
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)

rayphi avatar Aug 27 '20 11:08 rayphi

I have same error image

chenshuai2144 avatar Sep 01 '20 11:09 chenshuai2144

This caused by PSReadLine itself

Error Case:

  1. Create a filename that requires surrogate pairs, include a πŸ–₯️ or πŸ˜€
  2. copy a path to your clipboard
  3. type gi ' then paste the path

File not found

I verified gi (get-clipboard) does have the right path.

Working Case: Remove-Module

  1. run Remove-Module PSReadLine
  2. Paste like the first test

Get-Item does find the file

image

Notes:

It doesn't seem to matter whether the 3 encodings are set to utf16le vs utf8 [console]::InputEncoding, [console]::OutputEncoding, $OutputEncoding

Even though the terminal didn't render the runes correctly, the paste still was the valid path image

ninmonkey avatar May 01 '21 22:05 ninmonkey

Revisiting this issue, I dont seem to get any errors copying and pasting large sets of emojis in Windows Terminal with PowerShell 7.3.1 and PSReadLine 2.2.6

image

Without windows Terminal it seems to be okay but has little different rendering and a few ??

image

With Mac it gets a little messy with more than like 2 emojis, see screen recording

Uploading Screen Recording 2023-01-04 at 9.14.48 AM.mov…

StevenBucher98 avatar Jan 04 '23 17:01 StevenBucher98

Has this issue been fixed? Whenever i enter a emoji like πŸ€‘the windows terminal shows οΏ½ οΏ½ instead of rendering the proper emoji in the terminal when inputting an emoji The information provided here is confusing me that is why asking.

UsmanTariq2 avatar Feb 07 '24 11:02 UsmanTariq2