email-validate-hs icon indicating copy to clipboard operation
email-validate-hs copied to clipboard

testsuite failing in Stackage Nightly

Open juhp opened this issue 4 years ago • 1 comments
trafficstars

Test suite failure for package email-validate-2.3.2.13

    src/Text/Email/Parser.hs:15:1: error:                                                                                   [8/9960]
        Could not load module ‘Data.Attoparsec.ByteString.Char8’
        It is a member of the hidden package ‘attoparsec-0.13.2.4’.
        You can run ‘:set -package attoparsec’ to expose it.
        (Note: this unloads all the modules in the current scope.)
        Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    
    src/Text/Email/Parser.hs:16:1: error:
        Could not load module ‘Data.ByteString’
        It is a member of the hidden package ‘bytestring-0.10.12.0’.
        You can run ‘:set -package bytestring’ to expose it.
        (Note: this unloads all the modules in the current scope.)
        Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    
    src/Text/Email/Parser.hs:17:1: error:
        Could not load module ‘Data.ByteString.Char8’
        It is a member of the hidden package ‘bytestring-0.10.12.0’.
        You can run ‘:set -package bytestring’ to expose it.
        (Note: this unloads all the modules in the current scope.)
        Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    src/Text/Email/QuasiQuotation.hs:23: failure in expression `[email|[email protected]|]'
    expected: "[email protected]"
     but got: 
              ^
              <interactive>:25:1: error:
                  • Not in scope: ‘email’
                  • In the quasi-quotation: [email|[email protected]|]
    
    src/Text/Email/Validate.hs:41: failure in expression `canonicalizeEmail "spaces. are. [email protected]"'
    expected: Just "[email protected]"
     but got: 
              ^
              <interactive>:39:1: error:
                  Variable not in scope: canonicalizeEmail :: t0 -> t
    
    src/Text/Email/Validate.hs:56: failure in expression `validate "[email protected]"'
    expected: Right "[email protected]"
     but got: 
              ^
              <interactive>:47:1: error:
                  Variable not in scope: validate :: t0 -> t
    
    Examples: 6  Tried: 5  Errors: 0  Failures: 3

This was with ghc-8.10.3

juhp avatar Dec 30 '20 02:12 juhp

Hmm actually this may well be a stackage build issue.

juhp avatar Dec 30 '20 04:12 juhp

I don't think it's a Stackage issue, it is more likely an issue with the doctest setup, since it doesn't consider environment files and it doesn't use cabal-doctest either. The tests pass if run with the new REPL invocation mode available in doctest-0.20.1:

cabal repl --with-ghc=doctest --ghc-options="-XQuasiQuotes -XOverloadedStrings"

And the package could be added back to Nightly when #65 is merged. The Stackage CI probably can't run the doctests, but that isn't a huge issue to me.

ysangkok avatar Nov 19 '22 18:11 ysangkok

@Porges I see you removed doctest as a build dependency in recent commits. Would it be possible to make a release? Then Stackage wouldn't need to make an exception for

  • commercialhaskell/stackage/issues/6875

ysangkok avatar Apr 22 '23 15:04 ysangkok

@ysangkok This is now done.

Porges avatar Jul 26 '23 21:07 Porges