pba-content icon indicating copy to clipboard operation
pba-content copied to clipboard

Published 20 hours ago • verified publisher icon Polkadot-Blockchain-Academy

markdown link checker and CI miss internal `<img .../>` links being broken

Open nuke-web3 opened this issue 2 years ago • 3 comments

This may break the build! We need a way to check all links inclusive of non md syntax explicit ones.

nuke-web3 avatar Jun 29 '23 19:06 nuke-web3

@wirednkod IIRC there was chatter about CI checking - any ideas on this one?

nuke-web3 avatar Jul 05 '23 16:07 nuke-web3

I cannot reproduce this behavior and I recommend we close this issue. Please see #687 where I introduce a broken link in exactly the kind of tag described here, and the CI properly catches it.

JoshOrndorff avatar Jul 05 '23 17:07 JoshOrndorff

@wirednkod IIRC there was chatter about CI checking - any ideas on this one?

I managed to reproduce (see here but dont merge). This PR (if build is run) has many link issues. I'll try to find the solution on that

wirednkod avatar Jul 05 '23 18:07 wirednkod