PluralKit icon indicating copy to clipboard operation
PluralKit copied to clipboard

fix(bot): Proxy tag size limit

Open Oliver-makes-code opened this issue 3 years ago • 4 comments
trafficstars

Having a proxy tag that's too big causes the bot to throw an error, I went in and created a size limit of 64 for prefix and suffix separately, as that sounded reasonable.

Oliver-makes-code avatar Sep 05 '22 01:09 Oliver-makes-code

Deploy Preview for pluralkit canceled.

Name Link
Latest commit e5ce9471053b266e3255e0b511c7e65e56a9c34e
Latest deploy log https://app.netlify.com/sites/pluralkit/deploys/6315529454ef0d000930f792

netlify[bot] avatar Sep 05 '22 01:09 netlify[bot]

If a different size is needed, then feel free to tell me

Oliver-makes-code avatar Sep 05 '22 01:09 Oliver-makes-code

If a different size is needed, then feel free to tell me

The API has a limit of 100 characters for the entire tag including text. I think it's in Limits class, or it should be if it currently isn't

ghost avatar Sep 05 '22 20:09 ghost

I just noticed this doesn't build, can you fix the build issues? (and preferably test your code before you PR :p)

ghost avatar Sep 22 '22 18:09 ghost

fixed in 2745ee61564ef0694d5bae29eea771eaa982d3cd

ghost avatar Nov 22 '22 09:11 ghost