Bug: direct link to plant location does not work (first time)

[sunilsabatp]

Fix : Previously, visiting a plant location via a direct link in an incognito tab (e.g., https://dev.pp.eco/en/yucatan?ploc=JOCK9R) redirected to the default site instead of the specified plant location. This fix ensures the correct plant location is resolved and displayed when accessing such links, even in incognito mode.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 26, 2025 6:06am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			May 26, 2025 6:06am
planet-webapp-temp	⬜️ Ignored (Inspect)			May 26, 2025 6:06am

[coderabbitai[bot]]

"""

Walkthrough

The pull request introduces subtle modifications across four files in the projectsV2 feature: ImageSection.tsx, ProjectsContext.tsx, SingleProjectView.tsx, and projectV2.ts. The primary changes involve adding null checks for plantLocations in various useEffect hooks, simplifying a conditional statement in the handleBackButton function, and modifying the path localization logic to allow more flexible path handling.

Changes

File	Change Summary
src/features/projectsV2/ProjectSnippet/microComponents/ImageSection.tsx	Simplified handleBackButton function's conditional statement by removing braces.
src/features/projectsV2/ProjectsContext.tsx	Added plantLocations null checks in two useEffect hooks and included plantLocations in dependency arrays.
src/features/projectsV2/ProjectsMap/SingleProjectView.tsx	Added requestedPlantLocation extraction from router query; updated useEffect hooks to include new dependencies and null checks for plantLocations; refined zoom logic conditions.
src/utils/projectV2.ts	Modified getLocalizedPath function to treat locale path (/${locale}) as root path, enabling localized root path handling without trailing slash.

Possibly related PRs

• #2408: Modifies getLocalizedPath in src/utils/projectV2.ts to improve locale path handling, directly related to this PR's changes in the same function.
• #2296: Updates routing logic for v2 projects including removal of /prd prefix and archiving old project pages, related to this PR's routing and path handling adjustments.

Suggested labels

PR: reviewed-changes-requested

Suggested reviewers

• mohitb35
• mariahosfeld

Poem

🐇 In code fields where the logic grows,
Null checks guard where the wild wind blows,
Paths now know their locale's face,
And back buttons move with subtle grace.
A rabbit hops through code so bright,
Keeping errors out of sight! 🌿✨
🥕🐾 """

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c5f0dbeede1733903f1aa73b92d400aacb1d477 and cad42c744b67bf719f486145855f8ee9b67f0249.

📒 Files selected for processing (2)

• src/features/projectsV2/ProjectsContext.tsx (3 hunks)
• src/features/projectsV2/ProjectsMap/SingleProjectView.tsx (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/features/projectsV2/ProjectsContext.tsx
• src/features/projectsV2/ProjectsMap/SingleProjectView.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ESLint on Ubuntu
• GitHub Check: Analyze (javascript)

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sunilsabatp]

@sunilsabatp There are a few issues with the changes that add a null check for plantLocations before loading data

1. Instead of checking plantLocations = null and blocking site selection (url update) / map zoom when not needed, introduce a dedicated isLoadingPlantLocations state. This way the purpose is more explicit.
2. Check the isLoadingPlantLocations only when needed e.g. when ploc is passed as a url query param, or a selectedPlantLocation exists.
3. The current implementation prevents site loading when the project is not a tree purpose project. e.g. conservation-aa-andes

You might want to consider separating site selection logic from plant location handling (perhaps not now, but as part of a near future update)

Instead of introducing a new state, I followed a different approach. Please review it and provide your feedback.

[mohitb35]

@sunilsabatp Can we close this?

[sunilsabatp]

@sunilsabatp Can we close this?

Yes, we should close this. I’ve tested the dev branch multiple times, and direct visits to the intervention using query parameters are working perfectly fine.

[mohitb35]

Not needed as issue fixed by #2352