Projects redesign/project details

[sunilsabatp]

This PR takes care the Project info section which includes

• project card
• about us
• project review
• project info
• contact details
• dive to map (only for mobile)

how to test ? visit -> /locale/prd/[project slug]

• [x] project details sidebar (base PR)
  • [x] conservation
  • [x] restoration - tree
  • [x] restoration - m2
• [x] unsupported project types (bouquet, funding) redirect to /prd with an error
• [x] site functionality
  • [x] site selection on map
  • [x] dropdown
  • [x] zoom into site
• [ ] mobile controls
  • [ ] explore (to check layout, comment out before release)
  • [x] sites dropdown
• [x] plant location functionality (excluding selection on mobile)
• [ ] sample plant location functionality (temporary)
• [x] show satellite layer by default if no plant locations exist
• [ ] hide plant locations if satellite view is selected (in review)
• [ ] static image of site on map (backend?)
• [x] ~~use existing slide up view (mobile) for plant location details --- cancelled~~
• [x] direct url visit with ploc parameter (in review - plant location PR #2211)
• [x] direct url visit with site parameter (in review - plant location PR #2211)
• [ ] sample plant location/ plant location functionality (swipeable layout)
• [ ] The back button logic does not seem right, perhaps this can be taken up in a separate PR though.
• [ ] Bug on safari iOS - nav controls are overlapped by browser address bar (in review - this PR)
• [ ] Evaluate styles/classes defined for KeyInfo / AdditionalInfo. For example, we have no class defined called infoDetail but this is used in AdditionalInfo, and KeyInfo has code which results in nested singleRowInfoContainer classes. Refactor, and rename where needed. (sep PR)
• [ ] consolidate translations
• [ ] consolidate utils
• [ ] Consolidated UI check - list page
  • [ ] mobile
  • [ ] desktop
• [ ] Consolidated UI check - details page
  • [ ] mobile
  • [ ] desktop
• [ ] Handle projects without sites e.g. agroforestry-to-assist-forest-restoration-in-the-dry-bolivian-andes
  • [ ] zoomToSingleTreeLocation is already defined
• [ ] show whole area functionality for sample plant location info

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview		Oct 11, 2024 6:00am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Oct 11, 2024 6:00am
planet-webapp-temp	⬜️ Ignored (Inspect)			Oct 11, 2024 6:00am

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mariahosfeld]

Check again for design consistency. On mobile: Some components are not taking the same width as others, e.g., the image slider and the video are more width.

[mohitb35]

UI

• [x] The trees donated count should be formatted into millions once it crosses a million. Also, only integer value should be seen while displaying the whole count.
• e.g. 1. 26,551,073.21 Trees donated ---> 26.5m Trees donated
• e.g. 2. 3,392.2 Trees donated --> 3,392 Trees donated
• [ ] Font sizes need a review, as mentioned in https://github.com/Plant-for-the-Planet-org/planet-webapp/pull/2183#pullrequestreview-2260731523
• [x] The box shadow may need some adjustment, especially when it falls between the scrollbar and the side of the project info container. --> Reduce x, y values to 0, blur to 10px. See if this needs to be updated anywhere else as well.
• [x] I noticed that the padding of sections above the image slider is different from the sections below (this is in the design too). Does that need adjustment? The sections above have 16px padding, and the sections below have 24px. @gangakhushlani - keep common 16px
• [x] 5. The image slider modal (full screen) functionality is no longer seen. Needs to be added in. @gangakhushlani need a design for the full screen view (rounded corners for the image, close button outside?)
• [x] 6. Contact details - the bottom margin below the email results in inconsistent spacing around this section. I'd suggest using gap rather than margin to keep space between all the single contact detail containers.
• [x] 7. View Profile - I don't think the link is correct. It should be the tpo profile page.
• [x] 8. Project Spending - show integer values (rounded down), but preserve the other formatting.
• [x] 9. Back button - take the user to the new list page by default (unless they are coming from another site)
• [x] 10. On desktop, the Project Snippet background should be white. Instead it is currently transparent.
• [x] 11. The content in the Planting Density and Employees cells can get a little close. Can the min. space be increased a bit?
• [x]

[mohitb35]

Mobile specific UI

1. Project snippet UI varies from the design. This needs to be refactored for mobile view.

Design

Current UI

[mohitb35]

Mobile specific UI (contd.)

• [x] Also, the project snippet blends into the background as the section background matches with the page background. --> not an issue any more due to the above point, but provide explicit background color to the white portion of the snippet/whole snippet.
• [ ] What is to be shown as the background for the Dive into the project section.? @gangakhushlani to check and get back.

[mohitb35]

@sunilsabatp could you resolve the conflicts and address the functional / UI feedback above?

[mohitb35]

• [x] The price per unit shows up as 0 sometimes because the projects API is being called with a blank currency.

https://app-staging.plant-for-the-planet.org/app/projects/yucatan?_scope=extended&currency=&locale=de

[mariahosfeld]

I checked for the unsupportet project types, we already have the same behavior as in our current live deployment.

[mariahosfeld]

Please compare the headlines for the project details of this PR with the live system. We made some adjustments for restoration projects, that need to reflect in this PR as well (e.g. First Tree Planted = Restoration Started). Use the wording that is on the live system.

[mariahosfeld]

For conservation projects some data is missing, please compare to the live system.

[mariahosfeld]

If no data for a box is available it should be hidden (e.g. the box containing Main Challenge)

[mohitb35]

@mariahosfeld I think we need to list down information that should be seen in the project details for conservation and tree projects. We have 2 main sections below the image slider (KeyInfo and AdditionalInfo), and currently KeyInfo is shown only for tree projects. That logic isn't correct, but I think we need a definite list of information that can be seen.

[mariahosfeld]

Please make sure that all datapoint available via the API response are shown in the project details. For a conservation project several are missing.

[mariahosfeld]

For Site Ownership it needs to be ensured that we have an automatic break point if the space runs out, currently it is just cut off

[sunilsabatp]

For Site Ownership it needs to be ensured that we have an automatic break point if the space runs out, currently it is just cut off

The feature is scrollable, allowing you to scroll if the content of the site ownership type overflows.