pipedream
pipedream copied to clipboard
Add guest gender dob
WHY
Resolves #19336
Summary
Add optional gender and dateOfBirth fields to Booking Experts guest creation and update actions so components can send these attributes to the Booking Experts API.
This implements support for the Booking Experts guest update endpoint: https://developers.bookingexperts.com/reference/administration-reservation-guests-update
Changes
-
components/booking_experts/actions/update-guest/update-guest.mjs- Added optional
genderprop (options:male,female,other) - Added optional
dateOfBirthprop (expectsYYYY-MM-DD) - Send
genderanddate_of_birthin the API request attributes
- Added optional
-
components/booking_experts/actions/add-guest-to-reservation/add-guest-to-reservation.mjs- Added optional
genderprop (options:male,female,other) - Added optional
dateOfBirthprop (expectsYYYY-MM-DD) - Send
genderanddate_of_birthin the API request attributes
- Added optional
Summary by CodeRabbit
- New Features
- Added optional gender field (male, female, or other) when adding or updating guest information in reservations.
- Added optional date of birth field in YYYY-MM-DD format when adding or updating guest information in reservations.
✏️ Tip: You can customize this high-level summary in your review settings.
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
| Project | Deployment | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| pipedream-docs-redirect-do-not-edit | Dec 3, 2025 1:14pm |
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
- [ ] Create components to address specific use cases whenever possible
- [ ] Component
keys should follow the formatapp_name_slug-slugified-component-name - [ ] Components should follow the standard directory structure
- [ ] Prefer Node.js client libraries to REST APIs
- [ ] When making API requests, handle pagination to ensure all data / events are processed
- [ ] Use
secretprops to capture sensitive data - [ ] Props and methods should be defined in app files whenever possible
- [ ] Document methods with JS Docs
- [ ] Use
optionalprops whenever possible, and set adefaultvalue where you can - [ ] Use async options to accept user input wherever possible
Walkthrough
Two Booking Experts actions (add-guest-to-reservation and update-guest) add optional guest fields: gender and dateOfBirth; their runtime payloads now include gender and date_of_birth, and both action versions were bumped. Top-level package.json adds a devDependency (@types/glob) and the component package.json version under components/booking_experts was bumped.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Guest management actions components/booking_experts/actions/add-guest-to-reservation/add-guest-to-reservation.mjs, components/booking_experts/actions/update-guest/update-guest.mjs |
Version bumps (0.0.5→0.0.6 and 0.0.3→0.0.4). Added optional props: gender (string; options: male,female,other) and dateOfBirth (string; YYYY-MM-DD). Runtime payloads updated to include gender and date_of_birth. Minor description/formatting tweaks. |
Top-level manifest package.json |
Added devDependency @types/glob ^8.1.0 in devDependencies. |
Component manifest components/booking_experts/package.json |
Version bumped from 0.3.1 → 0.3.2. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
- Areas to inspect:
- Accurate mapping:
dateOfBirth→date_of_birthandgender→genderin all payloads. - Ensure optional props are handled when absent (no undefined fields sent if intended).
- Validate date format expectations/validation (YYYY-MM-DD) where inputs are consumed or documented.
- Verify version bumps (action and component) align with any release or registry requirements.
- Accurate mapping:
Pre-merge checks and finishing touches
❌ Failed checks (1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Out of Scope Changes check | ❓ Inconclusive | The package.json devDependency addition (@types/glob) appears unrelated to the gender/dateOfBirth feature and may represent out-of-scope changes. | Clarify the purpose of adding @types/glob devDependency and verify it is necessary for this PR or remove if unrelated to the guest attributes feature. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'Add guest gender dob' clearly summarizes the main change: adding gender and date of birth fields to guest-related actions. |
| Description check | ✅ Passed | The pull request description provides comprehensive context including issue reference, clear summary, specific changes to files, and implementation details for both actions. |
| Linked Issues check | ✅ Passed | The PR implementation fully addresses issue #19336 by adding gender and dateOfBirth support to both guest update and guest creation actions, matching the API documentation requirements. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
- [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Hi everyone, all test cases are passed! Ready for release!
Test reports
- [ACTION] Booking experts - update guests - Actions Batch 1: https://www.notion.so/ACTION-Booking-experts-update-guests-Actions-Batch-1-1-2bdbf548bb5e811e9dd5e8aea270641e
HI @manameaaus thanks for this great contribution, can you please increase just the version in package.json thanks! This is ready for QA!
Thank you for the reply @jcortes, I have made the suggested changes