Kate Lovett

Results 351 comments of Kate Lovett
trafficstars

I am inquiring with some folks to see if we can just update preferredSize to match the M3 spec. It would be a small breaking change, just a few pixels....

> We can also consider adding a flag like this [useLegacyColorScheme](https://master-api.flutter.dev/flutter/material/BottomNavigationBar/useLegacyColorScheme.html). (this was https://github.com/flutter/flutter/pull/107924 to BottomNavigationBar just a month ago) > Eventually, M2 will be deprecated and we can remove...

> If we add preferredSize to the PreferredSizeWidget then we would have one of them as redundant. Yeah I was thinking we could either have clear docs on both, maybe...

Hmm I really want to avoid legacy flags, they could end up being one of many in the future if we need to make other changes to the widget. Let...

We will, it will just be in a separate follow up change to the PreferredSize widget. We typically split up changes like this. Making a change to PreferredSize to accommodate...

Hey @elbeicktalat, I am going to close this PR. I do still have plans to support this without breaking the current spec (https://github.com/flutter/flutter/pull/107182 was an earlier proposal), I just haven't...

> Right now I don't believe there's a straightforward way to override a keyboard shortcut and a mouse gesture combined. I asked @gspencergoog about this recently, I was looking into...

Looks like there are some merge conflicts FYI

I am going to reopen this, since it is not the same issue.

I think @thkim1011's work on https://github.com/flutter/flutter/issues/33137 will make this possible by putting a pinned sliver persistent header in a SliverGroup (which is the feature they are working on).