flutter_reactive_ble icon indicating copy to clipboard operation
flutter_reactive_ble copied to clipboard

Published 20 hours ago • verified publisher icon PhilipsHue

ktlint -F

Open ened opened this issue 2 years ago • 2 comments

@remonh87

After running ktlint 0.50.0, the files in this PR were changed.

The formatting suggestions seem sensible to me, so I did not add a .editorconfig file.

ened avatar Jul 09 '23 19:07 ened

@Taym95 / @werediver FYI - as preparation for further PRs. May be sensible to add a .github actions extension

ened avatar Jan 16 '24 23:01 ened

Some new formatting changes with ktlint 1.1.1, checking again - pls do not merge

ened avatar Jan 16 '24 23:01 ened

@Taym95 could try to merge this one again, please keep in mind:

  • Doing this will likely break existing PRs that touch the Android codebase
  • .editorconfig was adjusted to keep the refactoring somewhat at bay (line length & field renames), but this should be addressed eventually (and .editorconfig removed again).
  • the GitHub token could get write permissions (or a separate ktlint token), so that the GH action modifies the PR directly

ened avatar Apr 07 '24 13:04 ened

@Taym95 could try to merge this one again, please keep in mind:

  • Doing this will likely break existing PRs that touch the Android codebase
  • .editorconfig was adjusted to keep the refactoring somewhat at bay (line length & field renames), but this should be addressed eventually (and .editorconfig removed again).
  • the GitHub token could get write permissions (or a separate ktlint token), so that the GH action modifies the PR directly

Yes sounds good, thanks!

Taym95 avatar Apr 07 '24 13:04 Taym95