firebase-python icon indicating copy to clipboard operation
firebase-python copied to clipboard

Suggestion for more better use..

Open budimm opened this issue 6 years ago • 2 comments

https://github.com/PhantomInsights/firebase-python/blob/master/auth/email/README.md

Really nice sample, but got something need to improve..

Need to exchange the variable,, the naming variable used is the library used, so in my code, i got some error, better in this code, change to req :

        req = urllib.request.Request( blablabla..

try:
        loader = urllib.request.urlopen(req)
getAccountInfo?key='+firebase_apikey,

Missing some punctuation..

Ok, thats for firebase auth..

budimm avatar Mar 26 '19 05:03 budimm

also wrong setting for request type..

my_data["requestType"] = "VERIFY_EMAIL"

budimm avatar Mar 26 '19 06:03 budimm

Thank you for your suggestions!

I originally made this repository when I was learning Python for a way to speed up my learning.

There's a lot of work to do, I'm planning to redo it all with all the things I have learned.

I'm still debating if to continue to use the urllib module or switch to Requests.

agentphantom avatar Mar 26 '19 14:03 agentphantom