SFP icon indicating copy to clipboard operation
SFP copied to clipboard

Crash if files are already patched.

Open GentlePuppet opened this issue 3 years ago • 5 comments

If the files are already patched then when it tries to patch them again it crashes entirely.

If you set it to patch on app launch this also causes it to instantly crash if the files are already patched.

SFP.log

GentlePuppet avatar Aug 20 '22 17:08 GentlePuppet

this is the problem:

2022-08-20 13:25:46.7036|ERROR|SFP.Models.Log|System.UnauthorizedAccessException: Access to the path 'c:\gaming programs\steam\steamui\css\library.css.old' is denied.

This file should not be in the steamui\css folder

PhantomGamers avatar Aug 20 '22 20:08 PhantomGamers

I see, I don't remember putting that there, but maybe it was a remenaint from the previous patcher. Removing it has solved this issue.

GentlePuppet avatar Aug 21 '22 00:08 GentlePuppet

It might have been from old glory or something, I don't believe this is from any of my software. Though I'm going to reopen this because it shouldn't crash so I'll fix it in the next release

PhantomGamers avatar Aug 21 '22 00:08 PhantomGamers

The only other patcher I had used was https://github.com/PhantomGamers/SteamFriendsPatcher Before that existed I was manually adding the @import to the library css with my own custom css file. And I never made any backup old files.

GentlePuppet avatar Aug 21 '22 00:08 GentlePuppet

I don't believe that patcher ever created .old files either so I'm not sure where that came from then 😅

PhantomGamers avatar Aug 21 '22 00:08 PhantomGamers