alpaca-java icon indicating copy to clipboard operation
alpaca-java copied to clipboard

Update enum value for FTX in Exchange

Open TonyMaganga opened this issue 3 years ago • 1 comments

The enum value for FTX in net.jacobpeterson.alpaca.model.endpoint.marketdata.crypto.common.enums.Exchange should be changed to "FXTU" to match the Crypto Pricing API .

`package net.jacobpeterson.alpaca.model.endpoint.marketdata.crypto.common.enums;

import com.google.gson.annotations.SerializedName; import java.util.HashMap; import java.util.Map;

public enum Exchange { @SerializedName("ERSX") ERISX("ERSX"), @SerializedName("FTX") FTX("FTX"),`

Currently an exception is thrown when getting trades

net.jacobpeterson.alpaca.rest.AlpacaClientException: Status Code: 422, Status Message: "Unprocessable Entity", API Response Code: 42210000, API Response Message: "invalid exchange: FTX" at net.jacobpeterson.alpaca.rest.AlpacaClient.request(AlpacaClient.java:207) at net.jacobpeterson.alpaca.rest.AlpacaClient.requestJSON(AlpacaClient.java:162) at net.jacobpeterson.alpaca.rest.AlpacaClient.requestObject(AlpacaClient.java:140) at net.jacobpeterson.alpaca.rest.AlpacaClient.requestObject(AlpacaClient.java:122) at net.jacobpeterson.alpaca.rest.endpoint.marketdata.crypto.CryptoMarketDataEndpoint.getLatestTrade(CryptoMarketDataEndpoint.java:122)

TonyMaganga avatar Jun 23 '22 09:06 TonyMaganga

@TonyMaganga thanks for reporting this. I'll fix this in a release sometime next week.

Petersoj avatar Jun 23 '22 14:06 Petersoj

@Petersoj just want to remind you of this bug. Please look into it

TonyMaganga avatar Aug 16 '22 13:08 TonyMaganga

@TonyMaganga thanks for the follow up! I'll issue a patch release later today.

Petersoj avatar Aug 16 '22 16:08 Petersoj

Fixed in 9.1.2.

Petersoj avatar Aug 17 '22 04:08 Petersoj

Thanks. I have tested it and works fine

TonyMaganga avatar Aug 17 '22 07:08 TonyMaganga