Refactor to run DNS query in parallel for speed up

[PeterDaveHello]

🚀

Summary by CodeRabbit

• New Features

  • Introduced a temporary directory management system for improved DNS checking
  • Enhanced concurrent processing of multiple DNS queries
  • Added background job handling and cleanup mechanism

• Performance

  • Optimized DNS checking to run asynchronously
  • Improved script efficiency for handling multiple domain checks

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The pull request introduces a temporary directory management system for the DNS checking script. A new temporary directory is created at the script's start, with a cleanup function defined to remove the directory and terminate background jobs upon script exit or interruption. The DNS checking functions are modified to run domain checks asynchronously, using background processes and temporary files to store results. This approach allows for concurrent processing of multiple DNS queries, improving the script's efficiency in handling domain checks.

Changes

File	Change Summary
chkdm	- Added tmp_dir variable for temporary directory management - Introduced cleanUp() function for directory and job cleanup - Modified DNS checking functions to use background processes - Implemented asynchronous result collection via temporary files

Sequence Diagram

sequenceDiagram
    participant Script as Main Script
    participant TempDir as Temp Directory
    participant DNSCheck as DNS Checker

    Script->>TempDir: Create temporary directory
    Script->>DNSCheck: Start background DNS checks
    DNSCheck-->>TempDir: Write results to temp files
    Script->>TempDir: Wait for result files
    TempDir-->>Script: Read DNS check results
    Script->>TempDir: Clean up temporary directory

Possibly related PRs

• #25: The addition of the warnUpDNS function introduces concurrent DNS queries, aligning with the main PR's asynchronous processing approach.
• #35: Removal of the Freenom World DNS entry from the nofilterDNS array, which impacts the DNS checks being performed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PeterDaveHello]

/review

[qodo-code-review[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Resource Cleanup The cleanUp function uses kill -9 which is a forceful termination. Consider using a less aggressive signal first (like SIGTERM) before resorting to SIGKILL. jobs -p | xargs kill -9 2>/dev/null Timeout Handling The DNS query polling loop has a hardcoded timeout of ~3 seconds (10 iterations * 0.3s sleep). This may not be sufficient for slow DNS responses and could lead to premature timeouts. for ((i=0; i<10; i++)); do printf "." if [ -f "$tmp_dir/nofilterDNS_$DNS" ]; then break fi sleep 0.3 done Race Condition The wait command is called after checking for file existence, which could lead to a race condition if the background process hasn't finished writing to the file yet. wait