Add test script

[PeterDaveHello]

:muscle:

Summary by CodeRabbit

• New Features

  • Added a comprehensive test script for domain validation testing.
  • Implemented parallel testing for valid and invalid domain checks.

• Chores

  • Updated CI configuration to use the new test script.
  • Improved test execution and reporting process.

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The pull request introduces a new Bash script test_chkdm.sh to replace direct calls to the chkdm script in the Travis CI configuration. The .travis.yml file has been updated to use this new script for testing domain validation. The new script provides a structured approach to testing valid and invalid domain names, with enhanced reporting and parallel test execution capabilities.

Changes

File	Change Summary
.travis.yml	Replaced direct chkdm script calls with ./test_chkdm.sh in Ubuntu and macOS test stages
test_chkdm.sh	New script added with functions for testing domain validation, including: - get_time_ms - format_duration - test_single_valid_domain - test_valid_domains - test_invalid_domains - check_chkdm_executable - main orchestration function

Sequence Diagram

sequenceDiagram
    participant CI as Travis CI
    participant TestScript as test_chkdm.sh
    participant Chkdm as chkdm executable
    
    CI->>TestScript: Execute test script
    TestScript->>TestScript: Check chkdm executable
    TestScript->>Chkdm: Test valid domains
    Chkdm-->>TestScript: Validation results
    TestScript->>Chkdm: Test invalid domains
    Chkdm-->>TestScript: Validation results
    TestScript-->>CI: Report test summary

Possibly related PRs

• #27: Changes in the chkdm script for domain name validation, relevant to the new test_chkdm.sh script.
• #28: Modifications to the .travis.yml file, directly related to updates made in this PR for testing purposes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PeterDaveHello]

/review

[qodo-code-review[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 Security concerns Command Injection: The script uses variables in command execution (e.g., $CHKDM) without proper quoting in some places. While the risk is low since inputs are controlled, it's best practice to always quote variables in bash scripts to prevent command injection vulnerabilities.

⚡ Recommended focus areas for review Race Condition The parallel test execution for valid domains uses temporary files to track results. While there is a trap to cleanup files, concurrent writes to the same file could potentially cause race conditions. for domain in "${valid_domains[@]}"; do echo -e " Testing domain: ${BLUE}$domain${NC}" ( if test_single_valid_domain "$domain"; then echo "1" > "$tmp_dir/$domain" else echo "0" > "$tmp_dir/$domain" fi ) & done wait Error Handling The script does not properly handle edge cases where get_time_ms fails or returns invalid values, which could cause incorrect duration calculations or script failures. get_time_ms() { if command -v gdate >/dev/null 2>&1; then gdate +%s%N elif date --version >/dev/null 2>&1 && date +%N >/dev/null 2>&1; then date +%s%N else echo $(($(date +%s) * 1000000000)) fi }