SpotifyAPI icon indicating copy to clipboard operation
SpotifyAPI copied to clipboard

Remove SpotifyExampleContent from SpotifyAPI in Swift Package

Open gregggreg opened this issue 2 years ago • 3 comments

If you include SpotifyAPI using Swift Package Manager, it includes the SpotifyExampleContent in your resulting app, adding several megabytes of unused content into your app. I've removed it from my fork and would love to see it merged so that I don't have to rely on my fork. Thanks, this project is super useful.

gregggreg avatar May 31 '23 17:05 gregggreg

here is the pull request:

https://github.com/Peter-Schorn/SpotifyAPI/pull/46

gregggreg avatar May 31 '23 17:05 gregggreg

+1, I just checked also and it's adding 4.8MB to my app 😱 @Peter-Schorn Are there any plans to spin off the SpotifyExampleContent into its own library that can then be pulled into SpotifyAPI when necessary? Happy to help out / work on it.

will-lumley avatar Jul 29 '23 03:07 will-lumley

I would accept a PR that moves SpotifyExampleContent into a separate library.

Peter-Schorn avatar Jul 29 '23 17:07 Peter-Schorn

Implemented in latest commit. Will be availble in next release.

Peter-Schorn avatar May 03 '24 01:05 Peter-Schorn

Implemented in version 3.0.0.

Peter-Schorn avatar May 26 '24 03:05 Peter-Schorn