perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

BBC: Blead Breaks DBD::XMLSimple

Open cjg-cguevara opened this issue 1 year ago • 6 comments

This is a bug report for perl from "Carlos Guevara" [email protected], generated with the help of perlbug 1.43 running under perl 5.41.4.


BBC: Blead Breaks DBD::XMLSimple

Please see http://fast-matrix.cpantesters.org/?dist=DBD::XMLSimple


Flags

  • category=core
  • severity=low

Perl configuration

Site configuration information for perl 5.41.4:

Configured by cpan at Mon Sep  2 12:37:30 EDT 2024.

Summary of my perl5 (revision 5 version 41 subversion 4) configuration:
  Commit id: 053b4620bf8cf1d7a4b0edcb6a587b46a38f7d32
  Platform:
    osname=linux
    osvers=5.14.0-427.33.1.el9_4.x86_64
    archname=x86_64-linux
    uname='linux cjg-rhel9 5.14.0-427.33.1.el9_4.x86_64 #1 smp preempt_dynamic fri aug 16 10:56:24 edt 2024 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dprefix=/home/cpan/bin/perl -Dscriptdir=/home/cpan/bin/perl/bin -Dusedevel -Duse64bitall'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='11.4.1 20231218 (Red Hat 11.4.1-3)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib /usr/lib64 /usr/local/lib64
    libs=-lpthread -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/lib/../lib64/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.34'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.41.4:
    /home/cpan/bin/perl/lib/site_perl/5.41.4/x86_64-linux
    /home/cpan/bin/perl/lib/site_perl/5.41.4
    /home/cpan/bin/perl/lib/5.41.4/x86_64-linux
    /home/cpan/bin/perl/lib/5.41.4

---
Environment for perl 5.41.4:
    HOME=/home/cpan
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LC_ALL=C
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/cpan/bin/perl/bin:/home/cpan/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

cjg-cguevara avatar Sep 02 '24 17:09 cjg-cguevara

This seems to be caused by https://github.com/Perl/perl5/pull/22507: !$p->depth==1. I guess this is a true positive, but neither interpretation seems very logical to me. Needs a ticket for sure in XML::Twig.

Leont avatar Sep 02 '24 17:09 Leont

This seems to be caused by #22507: !$p->depth==1. I guess this is a true positive, but neither interpretation seems very logical to me. Needs a ticket for sure in XML::Twig.

I'm puzzled by why you think we need a ticket in XML::Twig. It's passing all its tests. Can you clarify? Thanks.

jkeenan avatar Sep 02 '24 21:09 jkeenan

I'm puzzled by why you think we need a ticket in XML::Twig. It's passing all its tests. Can you clarify? Thanks.

The warning comes from XML::Twig. But DBD::XMLSimple is checking for warnings in its test, so then the (non-fatal) suddenly becomes a test failure.

Leont avatar Sep 02 '24 23:09 Leont

<[Tux]> mauke: http://www.cpantesters.org/cpan/report/be90f11a-68aa-11ef-b88e-dde1b1ec6beb
<dipsy> [ CPAN Testers Reports: FAIL Spreadsheet-Read-0.91 5.41.4 FreeBSD ] 
<mauke>   if( !$p->depth==1)
<mauke> yeah, that doesn't really make sense, but I can't tell what the intention was
<mauke> semantically, it's equivalent to if ($p->depth == 0)
<mauke> hah, this is in an if(  $t->{twig_root_depth} and ($p->depth == $t->{twig_root_depth}) ) block, so this condition is never true

Tux avatar Sep 03 '24 06:09 Tux

My brain parses that as unless ($p->depth == 1) { ... }, but of course that isnt what the code does.

demerphq avatar Sep 03 '24 09:09 demerphq

The XML::Twig ticket is here: https://rt.cpan.org/Ticket/Display.html?id=155759

eserte avatar Oct 12 '24 20:10 eserte